RDKB-58910, RDKB-64626 : Move the WAN IPV6 configuration from brlan0#172
Merged
Conversation
Signed-off-by: Parthiban Selvaraj <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates self-heal shell scripts to document the current (legacy) use of the LANIPv6GUASupport sysevent flag to gate certain WAN/ETH-WAN recovery and connectivity-check behaviors, and adds TODOs calling out the need for a more generic mechanism.
Changes:
- Add explanatory comments describing how
LANIPv6GUASupportis being interpreted in several self-heal code paths. - Add TODO notes indicating the current DHCP/self-heal approach is outdated and should be refactored away from region/product flags.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| scripts/task_health_monitor.sh | Adds comments/TODO around LANIPv6GUASupport usage and legacy DHCP self-heal behavior. |
| scripts/selfheal_bootup.sh | Adds comments/TODO explaining region-gated ETH WAN failover recovery logic. |
| scripts/selfheal_aggressive.sh | Adds comments/TODO explaining region-gated ETH WAN failover recovery logic. |
| scripts/self_heal_connectivity_test.sh | Adds comments/TODO explaining use of LANIPv6GUASupport to select IPoE-based health checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
S-Parthiban-Selvaraj
changed the title
This was referenced Apr 24, 2026
Merged
Merged
hpatel006c
approved these changes
May 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
scripts/task_health_monitor.sh:40
- The TODO contains a grammatical error (
from and Wanmanager) and inconsistent product capitalization, making the intended ownership unclear.
# TODO : DHCP selfheal mechanisms used here are outdated and dhcp should be controlled from and Wanmanager and the DHCPManager.
Comment on lines
+38
to
+40
| # Here LANIPv6GUASupport used to identify the region of the device. For example LANIPv6GUASupport is true for EU region devices and false for NA region devices. | ||
| # Eth WAN failover recovery action is taken only for NA region devices. | ||
| # TODO : DHCP selfheal mechanisms used here are outdated and dhcp should be controlled from and Wanmanager and the DHCPManager. |
| ifconfig -a >> /rdklogs/logs/dbg_wan_ip_missing.txt | ||
| } | ||
|
|
||
| # Here LANIPv6GUASupport used to identify the region of the device. For example LANIPv6GUASupport is true for EU region devices and false for NA region devices. |
| fi | ||
| fi | ||
|
|
||
| # Here LANIPv6GUASupport used to identify the region of the device. For example LANIPv6GUASupport is true for EU region devices and false for NA region devices. |
anoopchelakkode
pushed a commit
to rdkcentral/sysint-broadband
that referenced
this pull request
May 18, 2026
Reason for change: Create a /128 Ipv6 address using the received IA_PD Test Procedure: Updated in the JIra Risks: hign Priority: P0 Change-Id: Ic1fa9f5d0b4f0c01fb19de052db555481c78deb0 This PR is dependent on the following related PRs: rdkcentral/telco-voice-manager#5 rdkcentral/utopia#69 rdkcentral/wan-manager#79 rdkcentral/provisioning-and-management#127 rdkcentral/xconf-client#20 rdkcentral/test-and-diagnostic#172 https://github.com/rdk-gdcs/firewall/pull/5 #34 Signed-off-by: Parthiban Selvaraj <[email protected]> Co-authored-by: Santosh Nayak <[email protected]>
anoopchelakkode
pushed a commit
to rdkcentral/xconf-client
that referenced
this pull request
May 18, 2026
) Pull request overview Refactors IPv6 address detection in xb6_firmwareDwnld.sh to consistently use the WAN interface and remove device-/LAN-support-based branching, aligning with the goal of moving WAN IPv6 handling away from brlan0. Changes: Removes LANIPv6GUASupport usage and the associated conditional IPv6 interface-selection logic. Simplifies IPv6 presence detection in getFirmwareUpgDetail() to a single WAN-interface check. Simplifies IPv6 address extraction in the “wait for IP” loop by removing per-box-type branching. Refactor IPv6 address handling in xb6_firmwareDwnld.sh to simplify logic and remove redundant checks This PR is dependent on the following related PRs: rdkcentral/telco-voice-manager#5 rdkcentral/utopia#69 rdkcentral/wan-manager#79 rdkcentral/provisioning-and-management#127 #20 rdkcentral/test-and-diagnostic#172 https://github.com/rdk-gdcs/firewall/pull/5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR updates self-heal shell scripts to document the current (legacy) use of the
LANIPv6GUASupportsysevent flag to gate certain WAN/ETH-WAN recovery and connectivity-check behaviors, and adds TODOs calling out the need for a more generic mechanism.Changes:
LANIPv6GUASupportis being interpreted in several self-heal code paths.This PR is dependent on the following related PRs:
rdkcentral/telco-voice-manager#5
rdkcentral/utopia#69
rdkcentral/wan-manager#79
rdkcentral/provisioning-and-management#127
rdkcentral/xconf-client#20
#172
https://github.com/rdk-gdcs/firewall/pull/5
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
LANIPv6GUASupportusage and legacy DHCP self-heal behavior.LANIPv6GUASupportto select IPoE-based health checks.💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.