RDKB-58910 : Move the WAN IPV6 configuration from LAN bridge

[S-Parthiban-Selvaraj]

This PR moves WAN IPv6 configuration from the LAN bridge to the WAN interface itself, addressing an issue where IANA is not assigned by the BNG (Broadband Network Gateway). The changes enable the creation of IPv6 addresses on WAN interfaces from delegated prefixes when IANA addresses are not provided.

Key changes:

Removed IPv6 configuration from LAN bridge and moved it to WAN interfaces
Added new function to construct WAN IPv6 addresses from IAPD (IA Prefix Delegation)
Updated IPv6 utility functions to work with virtual interfaces instead of interface names
Cleaned up LAN-specific IPv6 handling code and legacy bridge mode logic

This PR is dependent on the following related PRs:
rdkcentral/telco-voice-manager#5
rdkcentral/utopia#69
#79
rdkcentral/provisioning-and-management#127
rdkcentral/xconf-client#20
rdkcentral/test-and-diagnostic#172
https://github.com/rdk-gdcs/firewall/pull/5
rdkcentral/sysint-broadband#34

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Corrected spelling of 'Canculate' to 'Calculate'.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 12 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

In DEL_ADDR, ip -6 route flush match is run with the interface IPv6 host address (...match <addr>). That will only flush routes whose destination matches that /128, and will not remove routes for the delegated prefix (e.g., the ip -6 route add <sitePrefix> dev brlan0 route added during PD handling). Please flush based on the delegated prefix (or remove the specific prefix route you added) rather than matching the /128 address.

Suggested change

	snprintf(cmdLine, sizeof(cmdLine), "ip -6 route flush match %s ", p_VirtIf->IP.Ipv6Data.address);
	snprintf(cmdLine, sizeof(cmdLine), "ip -6 route flush dev %s", p_VirtIf->Name);

[Copilot]

WanMgr_SendMsgToIHC now dereferences p_VirtIf unconditionally and no longer validates that the IPv4/IPv6 address fields are populated before sending (the previous implementation rejected empty/"(null)" values). Please add a null check for p_VirtIf and validate p_VirtIf->IP.Ipv4Data.ip / p_VirtIf->IP.Ipv6Data.address for the relevant message types to avoid sending empty addresses (or crashing if p_VirtIf is unexpectedly null).

[Copilot]

The new docstring for setUpLanPrefixIPv6 says it "Sets up the IPv6 /128 address for the LAN bridge" and that it "creates" the address, but the implementation no longer assigns an IPv6 address to brlan0 (it only sets sysevents and adds a route). Please update the comment to match the actual behavior (or restore the missing address assignment if it is still required).

[Copilot]

wanmgr_construct_wan_address_from_IAPD calls WanMgr_create_eui64_ipv6_address, but that helper is only compiled when FEATURE_RDKB_CONFIGURABLE_WAN_INTERFACE is defined (it is static inside that #if). Since wanmgr_construct_wan_address_from_IAPD is compiled unconditionally, builds that don't define FEATURE_RDKB_CONFIGURABLE_WAN_INTERFACE will fail (undefined symbol / implicit declaration). Please either move wanmgr_construct_wan_address_from_IAPD under the same feature guard, or provide a non-conditional implementation/declaration for the EUI-64 helper (or a fallback path).

Suggested change

	{
	char newPref[128] = {0};
	inet_ntop(AF_INET6, &prefix, newPref, sizeof(newPref));
	CcspTraceInfo(("%s %d EUI64 format is enabled using new prefix %s \n", __FUNCTION__, __LINE__, newPref));
	snprintf(cmdLine, sizeof(cmdLine), "%s/%d", newPref, prefix_length);
	WanMgr_create_eui64_ipv6_address(cmdLine, pIpv6DataNew->ifname, pIpv6DataNew->address);
	{
	#ifdef FEATURE_RDKB_CONFIGURABLE_WAN_INTERFACE
	char newPref[128] = {0};
	inet_ntop(AF_INET6, &prefix, newPref, sizeof(newPref));
	CcspTraceInfo(("%s %d EUI64 format is enabled using new prefix %s \n", __FUNCTION__, __LINE__, newPref));
	snprintf(cmdLine, sizeof(cmdLine), "%s/%d", newPref, prefix_length);
	WanMgr_create_eui64_ipv6_address(cmdLine, pIpv6DataNew->ifname, pIpv6DataNew->address);
	#else
	CcspTraceInfo(("%s %d EUI64 format is enabled in configuration but FEATURE_RDKB_CONFIGURABLE_WAN_INTERFACE is not defined; using WAN SUFFIX %d instead \n",
	__FUNCTION__, __LINE__, WAN_SUFFIX));
	prefix.s6_addr[15] = WAN_SUFFIX; // Setting the last byte for WAN address
	inet_ntop(AF_INET6, &prefix, pIpv6DataNew->address, sizeof(pIpv6DataNew->address));
	#endif

[Copilot]

cmdLine is only 128 bytes, but the new commands include an IPv6 literal (up to ~45 chars) plus an interface name up to BUFLEN_64 (DML_VIRTUAL_IFACE.Name), which can exceed 128 and get truncated by snprintf, causing the system action to fail. Please increase the buffer (e.g., BUFLEN_256) or compute the required length to ensure the full command is preserved.

[Copilot]

wanmgr_construct_wan_address_from_IAPD sets addrAssigned=true and returns 0 regardless of whether address generation or ip -6 addr add actually succeeded (return value from WanMgr_create_eui64_ipv6_address is ignored; WanManager_DoSystemActionWithStatus failure is only logged). This can leave WanManager believing an IPv6 address exists when it does not. Please check these return codes and propagate failure (return -1 and avoid updating addrAssigned / sysevents on failure).

[Copilot]

wanmgr_construct_wan_address_from_IAPD writes directly to stderr (fprintf(stderr, ...)) on parse failure. This bypasses the component logging used elsewhere and may not be captured in production logs. Please use the existing CcspTraceError logging (and include the offending prefix) instead of writing to stderr.

Suggested change

	fprintf(stderr, "Invalid IPv6 prefix\n");
	CcspTraceError(("%s %d Invalid IPv6 prefix: %s\n", __FUNCTION__, __LINE__, iapd_prefix));

[Copilot]

copyDhcpv6Data is a copy/helper routine but now has side effects (it may call wanmgr_construct_wan_address_from_IAPD, which runs ip -6 addr add and sets sysevents). Since DHCPv6 lease updates can arrive multiple times, this risks repeatedly trying to add the same /128 address (and doing potentially slow system calls while holding DhcpClientEvents_mutex). Please keep copyDhcpv6Data pure and move the WAN-address construction to the event-handling logic with proper idempotency (e.g., use ip -6 addr replace or check if the address is already present before adding).

Suggested change

	if(!pDhcpv6Data->addrAssigned && pDhcpv6Data->prefixAssigned)
	{
	/* In an IPv6 lease, if only IAPD is received and we never received IANA,
	* We can use the received IAPD to construct a Ipv6 /128 address which can be used for managerment and voice ...
	* If we reach this point, only IAPD has been received. Canculate Wan Ipv6 address
	*/
	CcspTraceInfo(("IANA is not assigned by DHCPV6. Constructing WAN address from the IAPD for Wan Interface \n"));
	wanmgr_construct_wan_address_from_IAPD(pDhcpv6Data);
	}

[Copilot]

This placeholder TODO (//TODO : **************************** Check this ************************) is not actionable and will be hard to triage later. Please either remove it or replace it with a specific TODO that states what needs to be verified and under what conditions (ideally with a ticket reference).

Suggested change

	//TODO : **************************** Check this ************************
	// TODO: Verify that the RBUS_WAN_IP IPv6 sysevent keys cleared below are correct for all product variants when WAN IPv6 goes down.

[Copilot]

wanmgr_dhcp_event_handler.c calls wanmgr_construct_wan_address_from_IAPD() but does not include the header that declares it (wanmgr_dhcpv6_apis.h). This will rely on an implicit declaration in some toolchains (or fail to compile under C99/C11 with -Werror=implicit-function-declaration). Please include the proper header or add a forward declaration.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 10 comments.

Comments suppressed due to low confidence (1)

source/WanManager/wanmgr_ipc.c:438

• WanMgr_SendMsgToIHC now dereferences p_VirtIf without validating it. Add a NULL check at the start of the function and fail early to avoid a crash if a caller passes NULL.

ANSC_STATUS WanMgr_SendMsgToIHC (ipoe_msg_type_t msgType, DML_VIRTUAL_IFACE *p_VirtIf )
{
    int sock = -1;
    int conn = -1;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The docstring says this function “sets up the IPv6 /128 address for the LAN bridge” and “creates an IPv6 /128 address”, but the current implementation no longer assigns an address on brlan0 (it only derives an address and sets sysevents). Update the comment to reflect the actual behavior (or restore the address assignment if it’s still required here).

Suggested change

	* @brief Sets up the IPv6 /128 address for the LAN bridge.
	* This function creates an IPv6 /128 address for the LAN bridge,
	* configures all necessary system events for the IPv6 LAN,
	* and restarts the DHCPv6 server and RA server if required.
	* @brief Sets up IPv6-related configuration for the LAN bridge.
	* This function derives the LAN IPv6 prefix from the delegated prefix,
	* configures the relevant system events and IPv6 settings needed for
	* LAN IPv6 operation, and allows other components (such as the DHCPv6
	* and RA servers) to react to those changes as needed.

[Copilot]

The added //TODO : **************************** Check this ************************ is a placeholder and doesn’t describe an actionable task. Please replace it with a specific TODO (what/why) and ideally a ticket reference, or remove it if not needed.

Suggested change

//TODO : **************************** Check this ************************

[Copilot]

If ip -6 addr add ... fails, the function still continues and returns success. Propagate the failure (return -1) so callers don’t treat IPv6 as configured when it isn’t.

Suggested change

	if (WanManager_DoSystemActionWithStatus(__FUNCTION__, cmdLine) != 0)
	CcspTraceError(("failed to run cmd: %s", cmdLine));
	int rc = WanManager_DoSystemActionWithStatus(__FUNCTION__, cmdLine);
	if (rc != 0)
	{
	CcspTraceError(("failed to run cmd: %s", cmdLine));
	return -1;
	}

[Copilot]

ip -6 route flush match expects a prefix/CIDR. Flushing with p_VirtIf->IP.Ipv6Data.address (without /128) is likely a no-op/error and won’t remove routes for the delegated prefix. Use an appropriate CIDR (e.g., the delegated prefix in sitePrefix or %s/128 for the host route) and keep the first argument to WanManager_DoSystemActionWithStatus as a stable log tag rather than the full command string.

Suggested change

	snprintf(cmdLine, sizeof(cmdLine), "ip -6 route flush match %s ", p_VirtIf->IP.Ipv6Data.address);
	if (WanManager_DoSystemActionWithStatus(cmdLine, cmdLine) != 0)
	snprintf(cmdLine, sizeof(cmdLine), "ip -6 route flush match %s/128", p_VirtIf->IP.Ipv6Data.address);
	if (WanManager_DoSystemActionWithStatus("ip -6 route flush match ADDR/128", cmdLine) != 0)

[Copilot]

Before sending IPOE_MSG_WAN_CONNECTION_IPV6_UP, validate that p_VirtIf->IP.Ipv6Data.address is non-empty (and ideally a valid IPv6 string). Otherwise IHC can receive an “UP” message with an empty/invalid IPv6 address.

[Copilot]

This helper is documented as returning -1 on failure, but it always returns 0 even when a system command fails. Propagate the command failure status (and return -1) so callers can react appropriately.

[Copilot]

wanmgr_construct_wan_address_from_IAPD(&Ipv6DataNew) return value is ignored, but pNewIpcMsg->addrAssigned is forced true. If construction/assignment fails, IPv6 will be treated as up with no usable address. Gate addrAssigned updates on successful construction and handle the failure path.

Suggested change

	wanmgr_construct_wan_address_from_IAPD(&Ipv6DataNew);
	pNewIpcMsg->addrAssigned = true;
	/* Construct WAN IPv6 address from the delegated prefix only if possible. */
	if (wanmgr_construct_wan_address_from_IAPD(&Ipv6DataNew) == 0)
	{
	Ipv6DataNew.addrAssigned = true;
	pNewIpcMsg->addrAssigned = true;
	}
	else
	{
	CcspTraceError(("%s %d Failed to construct WAN IPv6 address from IAPD. IPv6 address will not be marked as assigned.\n",
	__FUNCTION__, __LINE__));
	}

[Copilot]

Before sending IPOE_MSG_WAN_CONNECTION_UP, validate that p_VirtIf->IP.Ipv4Data.ip is non-empty (and ideally a valid IPv4 string). Otherwise IHC can receive an “UP” message with an empty/invalid IPv4 address.

[Copilot]

ip -6 addr change generally requires an address with prefix length (e.g., .../128). p_VirtIf->IP.Ipv6Data.address is stored without a prefix length, so this command will fail and lifetimes won’t be updated. Append the correct prefix length (likely /128) when building the command.

Suggested change

	snprintf(cmdLine, sizeof(cmdLine), "ip -6 addr change %s dev %s valid_lft %d preferred_lft %d ", p_VirtIf->IP.Ipv6Data.address, p_VirtIf->Name, p_VirtIf->IP.Ipv6Data.prefixVltime, p_VirtIf->IP.Ipv6Data.prefixPltime);
	snprintf(cmdLine, sizeof(cmdLine), "ip -6 addr change %s/128 dev %s valid_lft %d preferred_lft %d ", p_VirtIf->IP.Ipv6Data.address, p_VirtIf->Name, p_VirtIf->IP.Ipv6Data.prefixVltime, p_VirtIf->IP.Ipv6Data.prefixPltime);

[Copilot]

Incrementing prefix.s6_addr[7] to pick the “next /64” only works for some prefix lengths (e.g., /56). For prefixes like /57, /60, /48 this can alter provider-assigned prefix bits and generate an address outside the delegated range. Compute the next /64 by incrementing the subnet-id bits between prefix_length and 64 (bitwise), rather than hardcoding byte 7.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

source/WanManager/wanmgr_dhcpv6_apis.c:2122

• setUpLanPrefixIPv6() no longer configures the computed global IPv6 address on brlan0 (the previous ip -6 addr add ... dev brlan0 call is gone), but it still adds a route via brlan0 and restarts LAN RA/DHCPv6 services. If no other component is responsible for assigning lan_ipaddr_v6 onto brlan0, LAN IPv6 will be broken. Please either restore the ip -6 addr add on the LAN bridge (with lifetimes), or clearly ensure/trigger the component that applies lan_ipaddr_v6 to the interface before restarting services.

        //Create a global IP for the LAN bridge from the received delegated prefix.
        ret = WanMgr_create_eui64_ipv6_address(pVirtIf->IP.Ipv6Data.sitePrefix, COSA_DML_DHCPV6_SERVER_IFNAME, globalIP);
        if(ret != 0) {
            CcspTraceInfo(("Assign global ip error \n"));
        }
        else 
        {
            snprintf(pVirtIf->IP.Ipv6Data.pdIfAddress, sizeof(pVirtIf->IP.Ipv6Data.pdIfAddress), "%s/64", globalIP);
            /*This is for brlan0 interface */
            char pref_len[10] ={0};
            sscanf (pVirtIf->IP.Ipv6Data.sitePrefix,"%*[^/]/%s" ,pref_len);
            sysevent_set(sysevent_fd, sysevent_token, "lan_prefix_v6", pref_len, 0);
            sysevent_set(sysevent_fd, sysevent_token, "lan_ipaddr_v6", globalIP, 0);
            sysevent_set(sysevent_fd, sysevent_token, "lan_prefix_set", globalIP, 0); //TODO: This was a event to Wanmanager. if no other process listens to it. remove it.
            sysevent_set(sysevent_fd, sysevent_token, SYSEVENT_FIELD_TR_BRLAN0_DHCPV6_SERVER_ADDRESS, globalIP, 0);
            CcspTraceInfo(("%s lan_ipaddr_v6 set to [%s]  \n", __FUNCTION__, globalIP));
        }
        memset(cmdLine, 0, sizeof(cmdLine));
        snprintf(cmdLine, sizeof(cmdLine), "ip -6 route add %s dev %s", pVirtIf->IP.Ipv6Data.sitePrefix, COSA_DML_DHCPV6_SERVER_IFNAME);
        if (WanManager_DoSystemActionWithStatus(__FUNCTION__, cmdLine) != 0)
        {

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

This TODO is non-actionable (“Check this” with asterisks) and doesn’t provide enough context for future maintainers. Please replace it with a specific description of what needs verification (and ideally a tracking ID/link), or remove it if it’s no longer needed.

Suggested change

//TODO : **************************** Check this ************************

[Copilot]

Typo in comment: “managerment” should be “management”.

Suggested change

	* We can use the received IAPD to construct a Ipv6 /128 address which can be used for managerment and voice ...
	* If we reach this point, only IAPD has been received. Canculate Wan Ipv6 address
	* We can use the received IAPD to construct a Ipv6 /128 address which can be used for management and voice ...
	* If we reach this point, only IAPD has been received. Calculate Wan Ipv6 address

[Copilot]

wanmgr_construct_wan_address_from_IAPD() marks addrAssigned=true and returns success even if address generation or ip -6 addr add ... fails. This can leave the state machine believing IPv6 is up while the interface has no usable address. Please check return codes from WanMgr_create_eui64_ipv6_address() and WanManager_DoSystemActionWithStatus() and propagate failures (and avoid setting addrAssigned/addrCmd on failure).

[Copilot]

wanmgr_construct_wan_address_from_IAPD() is declared unconditionally in the header, but its implementation depends on FEATURE_RDKB_CONFIGURABLE_WAN_INTERFACE (it writes addrAssigned/addrCmd fields that are feature-gated in WANMGR_IPV6_DATA, and it calls WanMgr_create_eui64_ipv6_address() which is only compiled under that same feature). This will break builds where the feature macro is off. Please either wrap the prototype+implementation in the same #if defined(FEATURE_RDKB_CONFIGURABLE_WAN_INTERFACE) guard, or make the needed struct fields / helper available unconditionally.

[Copilot]

Typo in comment: “managerment” should be “management”.

Suggested change

	* We can use the received IAPD to construct a Ipv6 /128 address which can be used for managerment and voice ...
	* We can use the received IAPD to construct a Ipv6 /128 address which can be used for management and voice ...

[Copilot]

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 7 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The default-route check uses popen() with a shell command string, while the rest of this function uses v_secure_popen()/v_secure_pclose(). For consistency with the secure-wrapper usage in this codebase and to avoid shell-invocation risks, use v_secure_popen() here as well (and close with v_secure_pclose()).

[Copilot]

wanmgr_construct_wan_address_from_IAPD() chooses the “next /64” by incrementing prefix.s6_addr[7] and then (when EUI-64 is enabled) calls WanMgr_create_eui64_ipv6_address() with the original delegated prefix length. This does not reliably produce a valid address on the intended /64 subnet for prefixes that are not already /64. Compute a proper /64 prefix for the selected WAN subnet and pass /64 into the EUI-64 generator (or construct the full /128 address directly from the /64).

Suggested change

	prefix.s6_addr[7] += 0x01; // Use next subnet for WAN. First /64 will be used for LAN.
	WanMgr_Config_Data_t *pWanConfigData = WanMgr_GetConfigData_locked();
	unsigned char IPv6EUI64FormatSupport = TRUE;
	if( NULL != pWanConfigData )
	{
	IPv6EUI64FormatSupport = pWanConfigData->data.IPv6EUI64FormatSupport;
	WanMgrDml_GetConfigData_release(pWanConfigData);
	}
	if(IPv6EUI64FormatSupport)
	{
	char newPref[128] = {0};
	inet_ntop(AF_INET6, &prefix, newPref, sizeof(newPref));
	CcspTraceInfo(("%s %d EUI64 format is enabled using new prefix %s \n", __FUNCTION__, __LINE__, newPref));
	snprintf(cmdLine, sizeof(cmdLine), "%s/%d", newPref, prefix_length);
	WanMgr_create_eui64_ipv6_address(cmdLine, pIpv6DataNew->ifname, pIpv6DataNew->address);
	}
	else
	{
	CcspTraceInfo(("%s %d EUI64 format is not enabled using WAN SUFFIX %d \n", __FUNCTION__, __LINE__, WAN_SUFFIX));
	prefix.s6_addr[15] = WAN_SUFFIX; // Setting the last byte for WAN address
	inet_ntop(AF_INET6, &prefix, pIpv6DataNew->address, sizeof(pIpv6DataNew->address));
	}
	{
	struct in6_addr wan_prefix = prefix;
	int bit_index = 0;
	/* Normalize the delegated prefix by clearing all bits after prefix_length. */
	for (bit_index = prefix_length; bit_index < 128; bit_index++)
	{
	wan_prefix.s6_addr[bit_index / 8] &= ~(0x80 >> (bit_index % 8));
	}
	/*
	* Select the WAN /64 subnet while keeping the first /64 available for LAN.
	* For prefixes shorter than /64, set the first subnet-id bit after the
	* delegated prefix. For /64 or longer prefixes, keep the normalized prefix.
	*/
	if (prefix_length < 64)
	{
	wan_prefix.s6_addr[prefix_length / 8] |= (0x80 >> (prefix_length % 8));
	}
	/* Convert the selected subnet into a clean /64 prefix. */
	for (bit_index = 64; bit_index < 128; bit_index++)
	{
	wan_prefix.s6_addr[bit_index / 8] &= ~(0x80 >> (bit_index % 8));
	}
	WanMgr_Config_Data_t *pWanConfigData = WanMgr_GetConfigData_locked();
	unsigned char IPv6EUI64FormatSupport = TRUE;
	if( NULL != pWanConfigData )
	{
	IPv6EUI64FormatSupport = pWanConfigData->data.IPv6EUI64FormatSupport;
	WanMgrDml_GetConfigData_release(pWanConfigData);
	}
	if(IPv6EUI64FormatSupport)
	{
	char newPref[128] = {0};
	inet_ntop(AF_INET6, &wan_prefix, newPref, sizeof(newPref));
	CcspTraceInfo(("%s %d EUI64 format is enabled using new prefix %s/64 \n", __FUNCTION__, __LINE__, newPref));
	snprintf(cmdLine, sizeof(cmdLine), "%s/64", newPref);
	WanMgr_create_eui64_ipv6_address(cmdLine, pIpv6DataNew->ifname, pIpv6DataNew->address);
	}
	else
	{
	CcspTraceInfo(("%s %d EUI64 format is not enabled using WAN SUFFIX %d \n", __FUNCTION__, __LINE__, WAN_SUFFIX));
	wan_prefix.s6_addr[15] = WAN_SUFFIX; // Setting the last byte for WAN address
	inet_ntop(AF_INET6, &wan_prefix, pIpv6DataNew->address, sizeof(pIpv6DataNew->address));
	}
	}

[Copilot]

SYSCFG_FIELD_IPV6_PREFIX_ADDRESS is set here to a WAN /128 address (<wan-address>/128). In the non-FEATURE_RDKB_CONFIGURABLE_WAN_INTERFACE path this syscfg key is used to store the delegated-prefix-derived LAN /64 address (pdIfAddress). Reusing the same syscfg key for different semantics across build flags is brittle and can break scripts that assume it always contains a “prefix address”. Consider introducing a dedicated syscfg key for the WAN /128 address or keep this key storing the LAN prefix address consistently.

[Copilot]

WanMgr_SendMsgToIHC() no longer validates its inputs. If p_VirtIf is NULL (or if the IPv4/IPv6 address fields are empty) this will either segfault or send an UP message with an empty address, which may break the health-check consumer. Add a NULL check and validate required address fields for the *_UP message types before sending.

[Copilot]

WanManager_Ipv6AddrUtil() deletes the IPv6 default route using ip -6 route delete default without scoping it to the interface. This can remove the active default route for a different WAN interface during failover/dual-WAN scenarios. Delete the default route for this specific interface (e.g., ... del default dev <if>), or rely on WanMgr_RemoveIPv6RouteAndAddress() which already does an interface-scoped deletion.

Suggested change

	snprintf(cmdLine, sizeof(cmdLine), "ip -6 route delete default");
	if (WanManager_DoSystemActionWithStatus("ip -6 route delete default", cmdLine) != 0)
	CcspTraceError(("failed to run cmd: %s", cmdLine));
	CcspTraceInfo(("%s-%d: Successfully deleted ipv6 default route\n", __FUNCTION__, __LINE__));
	snprintf(cmdLine, sizeof(cmdLine), "ip -6 route delete default dev %s", p_VirtIf->Name);
	if (WanManager_DoSystemActionWithStatus("ip -6 route delete default dev xxxx", cmdLine) != 0)
	CcspTraceError(("failed to run cmd: %s", cmdLine));
	CcspTraceInfo(("%s-%d: Successfully deleted ipv6 default route for interface %s\n", __FUNCTION__, __LINE__, p_VirtIf->Name));

[Copilot]

wanmgr_handle_dhcpv6_event_data() sets pNewIpcMsg->addrAssigned = true unconditionally after calling wanmgr_construct_wan_address_from_IAPD(). If address construction fails, the rest of the pipeline will believe an IPv6 address is present and may skip SLAAC detection / other recovery paths. Use the function's return value and only set addrAssigned on success (and consider copying the generated address back into the IPC struct if downstream code expects it).

Suggested change

	wanmgr_construct_wan_address_from_IAPD(&Ipv6DataNew);
	pNewIpcMsg->addrAssigned = true;
	if (wanmgr_construct_wan_address_from_IAPD(&Ipv6DataNew))
	{
	strncpy(pNewIpcMsg->address, Ipv6DataNew.address, sizeof(pNewIpcMsg->address));
	pNewIpcMsg->addrAssigned = true;
	}
	else
	{
	CcspTraceWarning(("%s %d Failed to construct WAN IPv6 address from IAPD. Keeping addrAssigned unset.\n", __FUNCTION__, __LINE__));
	}

[Copilot]

WanManager_Ipv6AddrUtil() flushes routes with ip -6 route flush match <IPv6-address>. Flushing by host address is unlikely to remove routes installed for the delegated prefix/site prefix and may leave stale routes behind. Consider flushing based on the relevant prefix (e.g., sitePrefix) or flushing routes dev <if> as appropriate for your routing model.

[Copilot]

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 8 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

setUpLanPrefixIPv6() sets SYSCFG_FIELD_IPV6_PREFIX_ADDRESS to "%s/128" using pVirtIf->IP.Ipv6Data.address. That is the WAN IPv6 address, not the LAN/PD-derived prefix address implied by the surrounding "create global IPv6 address (::1)" comment. Please base this syscfg value on the delegated prefix/LAN bridge address (e.g., globalIP or prefix + "::1") instead.

Suggested change

	strncpy(prefix, pVirtIf->IP.Ipv6Data.sitePrefix, index); // only copy prefix without the prefix length
	// Create and set IPv6 address with /128 prefix length //TODO: SYSCFG_FIELD_IPV6_PREFIX_ADDRESS may not be used anymore. Check and remove if not used in the NTP script
	char ipv6_addr_with_prefix[BUFLEN_64] = {0};
	snprintf(ipv6_addr_with_prefix, sizeof(ipv6_addr_with_prefix), "%s/128", pVirtIf->IP.Ipv6Data.address);
	strncpy(prefix, pVirtIf->IP.Ipv6Data.sitePrefix, index); // only copy prefix without the prefix length
	// Create and set IPv6 address with /128 prefix length from the delegated/LAN prefix //TODO: SYSCFG_FIELD_IPV6_PREFIX_ADDRESS may not be used anymore. Check and remove if not used in the NTP script
	char ipv6_addr_with_prefix[BUFLEN_64] = {0};
	size_t prefix_len = strlen(prefix);
	while (prefix_len > 0 && prefix[prefix_len - 1] == ':')
	{
	prefix[--prefix_len] = '\0';
	}
	snprintf(ipv6_addr_with_prefix, sizeof(ipv6_addr_with_prefix), "%s::1/128", prefix);

[Copilot]

wanmgr_construct_wan_address_from_IAPD() can return -1 on parse/validation failures, but this call ignores the return value and unconditionally sets pNewIpcMsg->addrAssigned = true. Please check the return status and only set addrAssigned/connected when the WAN address was successfully constructed and applied; otherwise keep addrAssigned false and log a clear error.

Suggested change

	/* In an IPv6 lease, if only IAPD is received and we never received IANA,
	* We can use the received IAPD to construct a Ipv6 /128 address which can be used for managerment and voice ...
	* If we reach this point, only IAPD has been received. Canculate Wan Ipv6 address
	*/
	CcspTraceInfo(("IANA is not assigned by DHCPV6. Constructing WAN address from the IAPD for Wan Interface \n"));
	wanmgr_construct_wan_address_from_IAPD(&Ipv6DataNew);
	pNewIpcMsg->addrAssigned = true;
	int ret = 0;
	/* In an IPv6 lease, if only IAPD is received and we never received IANA,
	* We can use the received IAPD to construct a Ipv6 /128 address which can be used for managerment and voice ...
	* If we reach this point, only IAPD has been received. Canculate Wan Ipv6 address
	*/
	CcspTraceInfo(("IANA is not assigned by DHCPV6. Constructing WAN address from the IAPD for Wan Interface \n"));
	ret = wanmgr_construct_wan_address_from_IAPD(&Ipv6DataNew);
	if (ret == 0)
	{
	Ipv6DataNew.addrAssigned = true;
	pNewIpcMsg->addrAssigned = true;
	}
	else
	{
	Ipv6DataNew.addrAssigned = false;
	pNewIpcMsg->addrAssigned = false;
	CcspTraceError(("%s %d Failed to construct WAN IPv6 address from IAPD. Leaving addrAssigned unset \n", __FUNCTION__, __LINE__));
	}

[Copilot]

wanmgr_construct_wan_address_from_IAPD() marks addrAssigned=true and logs the calculated address before attempting "ip -6 addr add". If the system command fails, the function only logs an error and still returns 0. Please treat command failures as hard errors: return -1 and avoid leaving addrAssigned set when the address wasn’t actually configured.

Suggested change

	pIpv6DataNew->addrAssigned = true;
	pIpv6DataNew->addrCmd = IFADDRCONF_ADD;
	CcspTraceInfo(("%s %d Calculated WAN address %s/128\n", __FUNCTION__, __LINE__, pIpv6DataNew->address));
	// Assign the /128 host address on the WAN interface
	memset(cmdLine, 0, sizeof(cmdLine));
	snprintf(cmdLine, sizeof(cmdLine), "ip -6 addr add %s/128 dev %s", pIpv6DataNew->address, pIpv6DataNew->ifname);
	if (WanManager_DoSystemActionWithStatus(__FUNCTION__, cmdLine) != 0)
	CcspTraceError(("failed to run cmd: %s", cmdLine));
	CcspTraceInfo(("%s %d Calculated WAN address %s/128\n", __FUNCTION__, __LINE__, pIpv6DataNew->address));
	// Assign the /128 host address on the WAN interface
	memset(cmdLine, 0, sizeof(cmdLine));
	snprintf(cmdLine, sizeof(cmdLine), "ip -6 addr add %s/128 dev %s", pIpv6DataNew->address, pIpv6DataNew->ifname);
	if (WanManager_DoSystemActionWithStatus(__FUNCTION__, cmdLine) != 0)
	{
	CcspTraceError(("failed to run cmd: %s", cmdLine));
	return -1;
	}
	pIpv6DataNew->addrAssigned = true;
	pIpv6DataNew->addrCmd = IFADDRCONF_ADD;

[Copilot]

This TODO marker ("**************************** Check this ************************") is non-actionable and doesn’t describe what needs to be verified or why. Please either remove it or replace it with a specific TODO (what to check, expected behavior, and a ticket/reference).

Suggested change

	//RBUS_WAN_IP
	//TODO : **************************** Check this ************************
	// RBUS_WAN_IP: reset the IPv6 address sysevent on the appropriate interface
	// based on product configuration.

[Copilot]

_ansc_strncpy(ipAddr, globalIP, sizeof(globalIP) - 1) can overflow/pad past the actual ipAddr buffer (e.g., WANMGR_IPV6_DATA.address is BUFLEN_48). Please pass the destination size into WanMgr_create_eui64_ipv6_address() (or use snprintf) and bound the copy to that size; also avoid unbounded _ansc_strcpy(globalIP, prefix).

Suggested change

	_ansc_strncpy(ipAddr, globalIP, sizeof(globalIP) - 1);
	snprintf(ipAddr, BUFLEN_48, "%s", globalIP);

[Copilot]

wanmgr_construct_wan_address_from_IAPD() header comment says it uses the “next available /64 subnet” and reserves the first /64 for LAN, but the implementation derives the WAN /128 from the first /64 (same /64 as LAN). Please update this header comment to match the implementation (or vice versa) so integrators don’t rely on incorrect subnet selection.

Suggested change

	* @brief Constructs a dedicated WAN IPv6 address from the received IAPD (IA Prefix Delegation).
	*
	* This function extracts the IPv6 prefix and its length from the given IAPD data. It then uses
	* the provided prefix to construct a unique WAN IPv6 address by using the next available /64 subnet.
	* The first /64 subnet of the IAPD is reserved for LAN, while the next /64 is used for the WAN address.
	* The constructed WAN address is assigned to the specified WAN interface.
	*
	* @param[in] pIpv6DataNew Pointer to the WANMGR_IPV6_DATA structure.
	*
	* @return
	* - 0 on success.
	* - -1 on failure (e.g., invalid prefix format, prefix length >= 64, or system command failure).
	*
	* @note The function assumes that if the prefix length is less than 64, there are sufficient bits available
	* to split the IAPD into multiple /64 subnets. If the prefix length is 64 or greater, it logs an error
	* and returns -1 since further subnetting is not possible.
	*
	* ### Example:
	* Given an IAPD of "2a06:5906:13:d000::/56", the function may construct the following addresses:
	* - LAN IPv6 Address Range: "2a06:5906:13:d000::/64"
	* - WAN IPv6 Address: "2a06:5906:13:d001::1/128"
	* @brief Constructs a WAN IPv6 address from the received IAPD (IA Prefix Delegation).
	*
	* This function extracts the IPv6 prefix and its length from the given IAPD data. It then derives
	* a WAN IPv6 /128 address from the first available /64 within the delegated prefix and assigns the
	* constructed WAN address to the specified WAN interface.
	*
	* @param[in] pIpv6DataNew Pointer to the WANMGR_IPV6_DATA structure.
	*
	* @return
	* - 0 on success.
	* - -1 on failure (e.g., invalid prefix format, prefix length >= 64, or system command failure).
	*
	* @note The function requires a delegated prefix length of less than 64 so that a /64 can be derived
	* from the IAPD. If the prefix length is 64 or greater, it logs an error and returns -1.
	*
	* ### Example:
	* Given an IAPD of "2a06:5906:13:d000::/56", the function may construct the following addresses:
	* - First /64 derived from the IAPD: "2a06:5906:13:d000::/64"
	* - WAN IPv6 Address: "2a06:5906:13:d000::1/128"

[Copilot]

The setUpLanPrefixIPv6() header says it “sets up the IPv6 /128 address for the LAN bridge”, but the function derives/records the LAN bridge address as “%s/64” in pdIfAddress and sets lan_ipaddr_v6 to the un-suffixed address. Please update the comment to match the actual configuration (and clarify whether LAN bridge is intended to be /64 vs /128).

Suggested change

	* @brief Sets up the IPv6 /128 address for the LAN bridge.
	* This function creates an IPv6 /128 address for the LAN bridge,
	* configures all necessary system events for the IPv6 LAN,
	* @brief Sets up the IPv6 /64 LAN bridge address derived from the delegated prefix.
	* This function creates and records the LAN bridge IPv6 address using a /64 prefix,
	* configures all necessary system events for the IPv6 LAN,

[Copilot]

The docstring says “If DAD fails, it also triggers a Router Solicitation”, but the current implementation only triggers RS when route_flag==0 (missing default route), not when dad_flag==0. Please update the comment (or adjust the logic) so documentation matches behavior.

Suggested change

	* This function checks the tentative address, detects Duplicate Address Detection (DAD) failure, and verifies the default route.
	* If DAD fails, it also triggers a Router Solicitation.
	* This function checks the tentative address, detects Duplicate Address Detection (DAD)
	* failure, and verifies that a default route is present.
	* If the default route is missing, it triggers a Router Solicitation.