RI-6570 Verify read operations for all key types in the browsers module #4723
+686
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* extend the API to support adding string keys * extend browser page locators to provide helper for checking the state of the keys details drawer * added e2e test to verify whether the information related to a string key is proplery displayed in the details drawer re #RI-6570
Code Coverage - Backend unit tests
Test suite run success2941 tests passing in 286 suites. Report generated by 🧪jest coverage report action from 76052ac |
* extend the API to support adding ttl to the hash keys * extend browser page locators to provide helper for checking the state of the hash keys details drawer * added e2e test to verify whether the information related to a hash key is proplery displayed in the details drawer re #RI-6570
* extend the API to support adding list keys * extend browser page locators to provide helper for checking the state of the list keys details drawer * added e2e test to verify whether the information related to a list key is proplery displayed in the details drawer re #RI-6570
valkirilov
force-pushed
the
feature/RI-6570/e2e-playwright-browser-keys-read
branch
from
1c596e2 to
f551b57
Compare
Code Coverage - Frontend unit tests
Test suite run success4792 tests passing in 628 suites. Report generated by 🧪jest coverage report action from 0b2f581 |
* extend the API to support adding ttl to set keys * extend browser page locators to provide helper for checking the state of the set keys details drawer * added e2e test to verify whether the information related to a set key is proplery displayed in the details drawer re #RI-6570
* extend the API to support adding sorted set keys * extend browser page locators to provide helper for checking the state of the sorted set keys details drawer * added e2e test to verify whether the information related to a sorted set key is proplery displayed in the details drawer re #RI-6570
* extend the API to support adding json keys * added e2e test to verify whether the information related to a json key is proplery displayed in the details drawer re #RI-6570
* extend the API to support adding ttl to stream keys * extend browser page locators to provide helper for checking the state of the stream keys details drawer * added e2e test to verify whether the information related to a stream key is proplery displayed in the details drawer re #RI-6570
valkirilov
requested review from
KrumTy,
pawelangelow,
dantovska,
ArtemHoruzhenko,
pd-redis and
KIvanow
as code owners
… to read re #RI-6570
pd-redis
reviewed
Jul 17, 2025
| const requestBody = { | ||
| keyName: Buffer.from(keyParameters.keyName, 'utf-8'), | ||
| members: keyParameters.members.map((member) => ({ | ||
| name: Buffer.from(member.name, 'utf-8'), |
There was a problem hiding this comment.
Buffer.from(member.name, 'utf-8') can be probably abstracted as a helper function
| async isKeyDetailsClosed(): Promise<boolean> { | ||
| try { | ||
| // Give a small moment for UI transitions to complete | ||
| await this.page.waitForTimeout(100) |
There was a problem hiding this comment.
this is flaky. Better wait for an element to show
There was a problem hiding this comment.
Totally agree, fixed.
| } | ||
| } | ||
|
|
||
| async getKeyTTL(): Promise<string | null> { |
There was a problem hiding this comment.
there is function declared in constructor with very similar name.
There was a problem hiding this comment.
Nice catch, refactored.
- remove fixed timeouts causing flaky results sometimes - export common logic for building string buffers and reuse it, as a helper function - cleanup unncesessary helper frunction in the browser objects
This was referenced Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new E2E tests to check the read functionality for different key types in the Browsers module. These tests make sure that when you click on a key, all its details show up correctly in the Details Panel (name, value(s), TTL, etc.).
How the tests work
Code Changes
How to run the tests
You can always refer to the README, but simply running the following command should do the trick for you