Fail when signature contains error #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you fix the CI? |
Signed-off-by: Jindrich Luza <[email protected]>
midnightercz
force-pushed
the
fail-signature-err
branch
from
f2e3c01 to
7069089
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #285 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 26 26
Lines 3246 3812 +566
==========================================
+ Hits 3246 3812 +566 ☔ View full report in Codecov by Sentry. |
querti
reviewed
Jan 30, 2025
| for reference, op_res in zip( | ||
| signed_results["operation"]["references"], signed_results["operation_results"] | ||
| ): | ||
| if op_res[0]["msg"]["errors"]: | ||
| LOG.error(f"Error signing {reference}: {op_res[0]['msg']['errors']}") | ||
| error = True |
There was a problem hiding this comment.
Why can't we raise an error here?
There was a problem hiding this comment.
Because I wanted to log all errors first and then fail
querti
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.