Create callback returns 403 when promise already completed #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfarr
commented
Dec 19, 2024
| @@ -313,7 +313,7 @@ func (d *DST) Run(r *rand.Rand, api api.API, aio aio.AIO, system *system.System) | |||
| func (d *DST) logNonLinearizable(ops []porcupine.Operation, history porcupine.LinearizationInfo) { | |||
| // log the linearizations | |||
| linearizations := history.PartialLinearizationsOperations() | |||
| util.Assert(len(linearizations) == 3, "linearizations must be equal to the number of partitions") | |||
| util.Assert(len(linearizations) == 4, "linearizations must be equal to the number of partitions") | |||
There was a problem hiding this comment.
This just fixes a whoopsie that made it to main
avillega
approved these changes
Dec 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #502 +/- ##
==========================================
- Coverage 56.18% 56.14% -0.05%
==========================================
Files 122 122
Lines 13332 13373 +41
==========================================
+ Hits 7491 7508 +17
- Misses 5390 5406 +16
- Partials 451 459 +8 ☔ View full report in Codecov by Sentry. |
avillega
reviewed
Dec 19, 2024
|
I totally forgot we do this so that any process creating a callback can just continue when the promise complete, duh! Will close this PR. I discovered this "issue" when using the new callback cli. Let's just log a different message indicating "the promise is already completed" in this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #500