Create callback returns 403 when promise already completed

internal/app/coroutines/createCallback.go

@@ -53,11 +53,11 @@ func CreateCallback(c gocoro.Coroutine[*t_aio.Submission, *t_aio.Completion, any
 			return nil, t_api.NewError(t_api.StatusAIOStoreError, err)
 		}
 
-		// If the callback was already created return 200 and an empty callback
-		var cb *callback.Callback
-		status := t_api.StatusOK
-
 		if p.State == promise.Pending {
+			// If the callback was already created return 200 and an empty callback
+			var cb *callback.Callback
+			status := t_api.StatusOK
+
 			mesg := &message.Mesg{
 				Type: message.Resume,
 				Root: r.CreateCallback.RootPromiseId,
@@ -112,19 +112,25 @@ func CreateCallback(c gocoro.Coroutine[*t_aio.Submission, *t_aio.Completion, any
 					CreatedOn: createdOn,
 				}
 			}
-		}
 
-		res = &t_api.Response{
-			Kind: t_api.CreateCallback,
-			Tags: r.Tags,
-			CreateCallback: &t_api.CreateCallbackResponse{
-				// Status could be StatusOk or StatusCreated if the Callback Id was already present
-				Status:   status,
-				Callback: cb,
-				Promise:  p,
-			},
+			res = &t_api.Response{
+				Kind: t_api.CreateCallback,
+				Tags: r.Tags,
+				CreateCallback: &t_api.CreateCallbackResponse{
+					Status:   status, // StatusCreated if the callback was created, otherwise StatusOk
+					Callback: cb,
+					Promise:  p,
+				},
+			}
+		} else {
+			res = &t_api.Response{
+				Kind: t_api.CreateCallback,
+				Tags: r.Tags,
+				CreateCallback: &t_api.CreateCallbackResponse{
+					Status: alreadyCompletedStatus(p.State),
+				},
+			}
 		}
-
 	} else {
 		res = &t_api.Response{
 			Kind: t_api.CreateCallback,

test/dst/dst.go

@@ -313,7 +313,7 @@
 func (d *DST) logNonLinearizable(ops []porcupine.Operation, history porcupine.LinearizationInfo) {
 	// log the linearizations
 	linearizations := history.PartialLinearizationsOperations()
-	util.Assert(len(linearizations) == 3, "linearizations must be equal to the number of partitions")
+	util.Assert(len(linearizations) == 4, "linearizations must be equal to the number of partitions")
 
 	// check each parition individually
 	// partitions are in order: promise, schedule, lock

test/dst/validator.go

@@ -331,6 +331,38 @@
 
 		return model, nil
 
+	case t_api.StatusPromiseAlreadyResolved:
+		if p == nil {
+			return model, fmt.Errorf("promise '%s' does not exist", req.CreateCallback.PromiseId)
+		}
+		if p.State != promise.Resolved && !(p.State == promise.Pending && p.Tags["resonate:timeout"] == "true" && resTime >= p.Timeout) {
+			return model, fmt.Errorf("promise '%s' not resolved", req.CreateCallback.PromiseId)
+		}
+		return model, nil
+	case t_api.StatusPromiseAlreadyRejected:
+		if p == nil {
+			return model, fmt.Errorf("promise '%s' does not exist", req.CreateCallback.PromiseId)
+		}
+		if p.State != promise.Rejected {
+			return model, fmt.Errorf("promise '%s' not rejected", req.CreateCallback.PromiseId)
+		}
+		return model, nil
+	case t_api.StatusPromiseAlreadyCanceled:
+		if p == nil {
+			return model, fmt.Errorf("promise '%s' does not exist", req.CreateCallback.PromiseId)
+		}
+		if p.State != promise.Canceled {
+			return model, fmt.Errorf("promise '%s' not canceled", req.CreateCallback.PromiseId)
+		}
+		return model, nil
+	case t_api.StatusPromiseAlreadyTimedout:
+		if p == nil {
+			return model, fmt.Errorf("promise '%s' does not exist", req.CreateCallback.PromiseId)
+		}
+		if p.State != promise.Timedout && !(p.State == promise.Pending && p.Tags["resonate:timeout"] != "true" && resTime >= p.Timeout) {
+			return model, fmt.Errorf("promise '%s' not timedout", req.CreateCallback.PromiseId)
+		}
+		return model, nil
 	case t_api.StatusPromiseNotFound:
 		if p != nil {
 			return model, fmt.Errorf("promise '%s' exists", req.CreateCallback.PromiseId)