Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security fix: Update peer dependencies with known vulnerabilities #1149

Merged
merged 6 commits into from
Apr 2, 2025

Conversation

achowdhry-ripple
Copy link
Collaborator

@achowdhry-ripple achowdhry-ripple commented Apr 1, 2025

High Level Overview of Change

reduces audit vulnerabilities number from 57 to 33.

ran audit, manually upgraded cross-spawn, shell-quote, babel/traverse peer dependencies for security fixes:

https://nvd.nist.gov/vuln/detail/CVE-2021-42740

https://nvd.nist.gov/vuln/detail/CVE-2024-21538

https://nvd.nist.gov/vuln/detail/CVE-2023-45133

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Translation Updates
  • Release

TypeScript/Hooks Update

  • Updated files to React Hooks
  • Updated files to TypeScript

Before / After

Test Plan

@achowdhry-ripple achowdhry-ripple changed the title update deps audit Security fix: Update cross-spawn and shell-quote Apr 1, 2025
@achowdhry-ripple achowdhry-ripple changed the title Security fix: Update cross-spawn and shell-quote Security fix: Update peer dependencies with known vulnerabilities Apr 1, 2025
@Patel-Raj Patel-Raj self-requested a review April 1, 2025 20:41
@achowdhry-ripple achowdhry-ripple marked this pull request as ready for review April 1, 2025 20:42
@achowdhry-ripple achowdhry-ripple merged commit f02844d into staging Apr 2, 2025
4 checks passed
@achowdhry-ripple achowdhry-ripple deleted the cross-spawn branch April 2, 2025 19:45
mvadari pushed a commit that referenced this pull request Apr 7, 2025
)

<!--
Please include a summary/list of the changes.
If too broad, please consider splitting into multiple PRs.
-->

reduces audit vulnerabilities number from 57 to 33.

ran audit, manually upgraded cross-spawn, shell-quote, babel/traverse
peer dependencies for security fixes:

https://nvd.nist.gov/vuln/detail/CVE-2021-42740

https://nvd.nist.gov/vuln/detail/CVE-2024-21538

https://nvd.nist.gov/vuln/detail/CVE-2023-45133

<!--
Please include the context of a change.
If a bug fix, when was the bug introduced? What was the behavior?
If a new feature, why was this architecture chosen? What were the
alternatives?
If a refactor, how is this better than the previous implementation?

If there is a design document for this feature, please link it here.
-->

<!--
Please check relevant options, delete irrelevant ones.
-->

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [x] Refactor (non-breaking change that only restructures code)
- [ ] Tests (You added tests for code that already exists, or your new
feature included in this PR)
- [ ] Documentation Updates
- [ ] Translation Updates
- [ ] Release

<!--
In an effort to modernize the codebase, you should convert the files
that you work with to React Hooks and TypeScript.
If this is not possible (e.g. it's too many changes, touching too many
files, etc.) please explain why here.
-->

- [ ] Updated files to React Hooks
- [ ] Updated files to TypeScript

<!--
If just refactoring / back-end changes, this can be just an in-English
description of the change at a technical level.
If a UI change, screenshots should be included.
-->

<!--
Please describe the tests that you ran to verify your changes and
provide instructions so that others can reproduce.
-->

<!--
For future tasks related to PR.
-->

---------

Co-authored-by: Chenna Keshava B S <[email protected]>
@mvadari mvadari mentioned this pull request Apr 7, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants