feat: added sie and sccountinhibit yaml files #1046
Conversation
sudo-apt-abdullah
requested review from
ThinkOpenly and
dhower-qc
as code owners
spec/std/isa/csr/scountinhibit.yaml
Outdated
| reset_value(): | | ||
| return COUNTINHIBIT_EN[0] ? UNDEFINED_LEGAL : 0; | ||
| sw_write(csr_value): | | ||
| if (implemented_csr?(CsrName::menvcfg) && CSR[menvcfg].CDE == 1'b0) { |
There was a problem hiding this comment.
Checking if menvcfg is implemented is correct, but it strays from how we have been handling these types of cases. Usually, we check for the extension that defines what is needed (in this case, S ~> 1.11). In IDL, this would be implemented_version?(ExtensionName::S, "~> 1.11")
There was a problem hiding this comment.
I've updated the condition (implemented_version?(ExtensionName::Sm, ">=1.12")) to first check if menvcfg is there, then raise exceptions based on menvcfg.CDE.
spec/std/isa/csr/scountinhibit.yaml
Outdated
| return COUNTINHIBIT_EN[0] ? UNDEFINED_LEGAL : 0; | ||
| sw_write(csr_value): | | ||
| if (implemented_csr?(CsrName::menvcfg) && CSR[menvcfg].CDE == 1'b0) { | ||
| if (mode() == PrivilegeMode::M) { |
There was a problem hiding this comment.
The spec says:
When menvcfg.CDE=0, attempts to access scountinhibit raise an illegal instruction exception.
So an Illegal Instruction should raise even in M mode.
There was a problem hiding this comment.
The condition is already there for M mode. I think you're talking about S mode which was missing, right? Let me know if I'm overlooking something!
spec/std/isa/csr/scountinhibit.yaml
Outdated
| if (mode() == PrivilegeMode::M) { | ||
| raise(ExceptionCode::IllegalInstruction, mode(), $encoding); | ||
| } | ||
| } else if (implemented_csr?(CsrName::menvcfg) && CSR[menvcfg].CDE == 1'b1) { |
There was a problem hiding this comment.
This check is too restrictive. It won't raise a Virtual Instruction if menvcfg is not implemented, but it should.
To fix, I think you just need to make this an "else".
There was a problem hiding this comment.
I've updated the conditions. Please have a look and suggest any further improvement if needed.
spec/std/isa/csr/scountinhibit.yaml
Outdated
| reset_value(): | | ||
| return COUNTINHIBIT_EN[2] ? UNDEFINED_LEGAL : 0; | ||
| sw_write(csr_value): | | ||
| if (implemented_csr?(CsrName::menvcfg) && CSR[menvcfg].CDE == 1'b0) { |
| definedBy: S | ||
| description: | | ||
| sie.STIE is the interrupt-enable bit for supervisor-level timer interrupts. | ||
| sw_write(csr_value): | |
There was a problem hiding this comment.
This (and all other bits in sie) needs to account for mideleg to determine if the bit has any effect
There was a problem hiding this comment.
I placed a check of respective bits from mideleg.
3 participants
Closes #563
Depends on #891
#910 has sieh.yaml that needs to serve as alias for sie which is in this PR!