refactor(pgwire): allow sharing of pg stream #20362
Merged
+84
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
BugenZhao
commented
Feb 3, 2025
|
|
||
| /// The logic of Conn is very simple, just a static dispatcher for TcpStream: Unencrypted or Ssl: | ||
| /// Encrypted. | ||
| pub enum Conn<S> { |
There was a problem hiding this comment.
Conn is removed because the variants are now under the Arc in PgStream, so that we can upgrading the underlying stream for all shared PgStream instances.
| pub struct PgStream<S> { | ||
| /// The underlying stream. | ||
| stream: Option<S>, | ||
| stream: Arc<Mutex<PgStreamInner<S>>>, |
There was a problem hiding this comment.
The overhead for this Mutex will be minimal since there won't be any contention during actual use.
8 tasks
chenzl25
approved these changes
Feb 8, 2025
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
force-pushed
the
bz/share-pg-stream
branch
from
3d41055 to
cb33f0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Refactor pgwire to allow
PgStreamto be cloned and used concurrently, so that we can use it to write messages asynchronously, typically forNotices.Checklist
Documentation
Release note