feat(pgwire): send notice asynchronously and promptly #20374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. |
BugenZhao
changed the title
BugenZhao
commented
Feb 4, 2025
st1page
approved these changes
Feb 5, 2025
BugenZhao
commented
Feb 7, 2025
src/utils/pgwire/src/pg_protocol.rs
Outdated
Comment on lines
240
to
245
| let next_notice = async { | ||
| let notice = session.next_notice().await; | ||
| notice_stream.write(&BeMessage::NoticeResponse(¬ice)).await.inspect_err(|e| { | ||
| tracing::error!(error = %e.as_report(), notice, "failed to send notice"); | ||
| }).ok(); | ||
| }; |
There was a problem hiding this comment.
This is not cancellation-safe.
There was a problem hiding this comment.
Could you explain more? I guess here no leaking will happen. And if the task is cancelled, it is ok to not send full notice to the user?
There was a problem hiding this comment.
Changed to not create a next_notice future every time when processing a message.
BugenZhao
force-pushed
the
bz/share-pg-stream
branch
from
3d41055 to
cb33f0e
Compare
BugenZhao
force-pushed
the
bz/async-pg-notice
branch
from
fe8e9be to
fc06eb5
Compare
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
force-pushed
the
bz/async-pg-notice
branch
from
f495a10 to
91f9e6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR refactors the
Sessiontrait andPgProtocolto enable sending notices asynchronously and promptly to users before a command completes.This is achieved by
selecting a new task for forwarding notice and the task for processing the command.Checklist
Documentation
Release note