Skip to content

chore: workflows launch post#4272

Merged
NathanFlurry merged 1 commit intomainfrom
02-23-chore_workflows_launch_post
Feb 24, 2026
Merged

chore: workflows launch post#4272
NathanFlurry merged 1 commit intomainfrom
02-23-chore_workflows_launch_post

Conversation

@NathanFlurry
Copy link
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4272 February 24, 2026 02:40 Destroyed
@railway-app
Copy link

railway-app bot commented Feb 24, 2026

🚅 Deployed to the rivet-pr-4272 environment in rivet-frontend

Service Status Web Updated (UTC)
website ❌ Build Failed (View Logs) Web Feb 24, 2026 at 8:37 am
frontend-cloud 😴 Sleeping (View Logs) Web Feb 24, 2026 at 8:05 am
frontend-inspector 😴 Sleeping (View Logs) Web Feb 24, 2026 at 7:44 am
mcp-hub ✅ Success (View Logs) Web Feb 24, 2026 at 2:41 am
ladle ❌ Build Failed (View Logs) Web Feb 24, 2026 at 2:41 am

Copy link
Member Author

NathanFlurry commented Feb 24, 2026


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Feb 24, 2026

PR Review: chore: workflows launch post

Scope: Website-only changes — new blog post for Rivet Workflows, unified CodeGroup layout, removal of Giscus comments, and responsive blog/changelog layout improvements.


High Severity

1. "TODO" placeholder in published post content
website/src/content/posts/2026-02-24-introducing-rivet-workflows/page.mdx

## Inspector

TODO

This section will be visible to readers. Must be filled in or removed before the post goes live.

2. workspace prop kept in interface but silently ignored in rendering
website/src/components/v2/Code.tsx

The workspace prop is retained in CodeGroupProps with a JSDoc comment, but it is not destructured in the function signature and has no effect on rendering. Every <CodeGroup> now renders the sidebar layout regardless. The intent (keeping it for the typecheck integration to distinguish multi-file snippets) is not documented in the comment. This should either:

  • Be clearly documented that the prop is type-check-only and has no visual effect, OR
  • The prop should be removed if the typecheck integration uses some other signal

3. initializeTabCodeGroup removed — existing docs pages may render incorrectly
website/src/components/TabsScript.astro

The tab-style initialization and click handler branch were both deleted. Any existing docs page using <CodeGroup> without workspace will now silently switch to the sidebar layout. This needs visual QA across all existing docs pages before merging.


Medium Severity

4. Missing React imports in type-checked code snippet (build may fail)
website/src/content/posts/2026-02-24-introducing-rivet-workflows/page.mdx — React Integration App.tsx block

useState and useEffect are used but not imported. Since this block is inside a <CodeGroup workspace> it will be type-checked during the website build:

// Missing at top of snippet:
import { useState, useEffect } from "react";

5. Anthropic model ID format in example code
website/src/content/posts/2026-02-24-introducing-rivet-workflows/page.mdx — Durable Agents example

model: anthropic("claude-sonnet-4-20250514"),

Verify this matches an actual published API string. Readers copying this snippet verbatim will receive an API error if the ID is incorrect.

6. "Show Me The Code" <CodeGroup> renders as sidebar instead of horizontal tabs
website/src/content/posts/2026-02-24-introducing-rivet-workflows/page.mdx

This block has 7 tabs (Basic, Human-in-the-Loop, Loop, Sleep, Join, Race, Rollback) and uses <CodeGroup> without workspace. After the unification, it will render a vertical sidebar navigator. Verify visually that this is the intended UX for this blog content before publishing.

7. Dead link risk: /docs/actors/workflows
website/src/content/posts/2026-02-24-introducing-rivet-workflows/page.mdx — "Get Started" section

The launch post links to /docs/actors/workflows. Confirm this page exists and is reachable before the post goes live.

8. ResizeObserver not disconnected on view transitions
website/src/components/TabsScript.astrosetupCodeGroupResponsiveLayout

Each ResizeObserver is created inside a closure with no external reference, which is fine for GC under normal conditions. However, on astro:after-swap the function is called again on new DOM nodes. Old observers attached to removed nodes should be GC'd by modern browsers, but since no explicit disconnect() is called, this is worth noting as a potential minor leak on low-memory environments or browsers with lazy GC.


Low Severity

9. Duplicate mobile author block — extract to shared component
website/src/pages/blog/[...slug].astro and website/src/pages/changelog/[...slug].astro

The lg:hidden mobile author section (~30 lines) is duplicated verbatim across both pages. Extracting to a shared Astro component would prevent future drift.

10. Bluesky social link removed without explanation
website/src/lib/article.tsx

-      bluesky: "https://bsky.app/profile/nathanflurry.com",

The removal is safe (all usages guard with ?.bluesky). Intentional, just confirming.


Pre-Merge Checklist

  • Resolve the "Inspector" TODO section
  • Add useState/useEffect imports to the React code snippet
  • Verify the Anthropic model ID string is a valid published identifier
  • Decide on CodeGroup architecture: document that workspace is type-check-only, or clean up the prop
  • Confirm /docs/actors/workflows is published and accessible
  • Visual QA of all existing docs pages using <CodeGroup> without workspace

@NathanFlurry NathanFlurry force-pushed the 02-23-chore_workflows_launch_post branch from 949362b to 3ec812e Compare February 24, 2026 08:36
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4272 February 24, 2026 08:36 Destroyed
@NathanFlurry NathanFlurry changed the base branch from graphite-base/4272 to main February 24, 2026 08:36
@NathanFlurry NathanFlurry marked this pull request as ready for review February 24, 2026 08:40
@NathanFlurry NathanFlurry merged commit 3d7000a into main Feb 24, 2026
12 of 30 checks passed
@NathanFlurry NathanFlurry deleted the 02-23-chore_workflows_launch_post branch February 24, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant