Skip to content

fix(rivetkit): use gatewayId instead of requestId in connection persistence log#4275

Merged
NathanFlurry merged 1 commit intomainfrom
fix_rivetkit_use_gatewayId_instead_of_requestId_in_connection_persistence_log
Feb 24, 2026
Merged

fix(rivetkit): use gatewayId instead of requestId in connection persistence log#4275
NathanFlurry merged 1 commit intomainfrom
fix_rivetkit_use_gatewayId_instead_of_requestId_in_connection_persistence_log

Conversation

@NathanFlurry
Copy link
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4275 February 24, 2026 03:59 Destroyed
@railway-app
Copy link

railway-app bot commented Feb 24, 2026

🚅 Deployed to the rivet-pr-4275 environment in rivet-frontend

Service Status Web Updated (UTC)
website ❌ Build Failed (View Logs) Web Feb 24, 2026 at 4:00 am
ladle ❌ Build Failed (View Logs) Web Feb 24, 2026 at 4:00 am
mcp-hub ✅ Success (View Logs) Web Feb 24, 2026 at 3:59 am
frontend-cloud ❌ Build Failed (View Logs) Web Feb 24, 2026 at 3:59 am
frontend-inspector ❌ Build Failed (View Logs) Web Feb 24, 2026 at 3:59 am

Copy link
Member Author

NathanFlurry commented Feb 24, 2026

@claude
Copy link

claude bot commented Feb 24, 2026

PR Review: fix(rivetkit): use gatewayId instead of requestId in connection persistence log

Status: LGTM - Simple, correct bug fix.

Summary

This is a one-line fix correcting a copy-paste error in the connection persistence log statement in state-manager.ts:464. The gatewayId field was accidentally being populated with hibernatableDataRaw.requestId instead of hibernatableDataRaw.gatewayId, causing the log to output the same value for both fields.

Assessment

Correctness: The fix is straightforwardly correct. Before the fix, the log entry had:

gatewayId: idToStr(hibernatableDataRaw.requestId)  // wrong - was using requestId
requestId: idToStr(hibernatableDataRaw.requestId)  // correct

After the fix, both fields reference their correct source properties.

No issues found:

  • The change is minimal and targeted
  • No logic is altered, only the log field source is corrected
  • No security or performance implications
  • Consistent with the existing structured logging pattern used throughout the codebase

This fix improves observability by ensuring the gatewayId field in persistence logs reflects the actual gateway ID rather than duplicating the request ID, which matters when debugging connection issues or tracing activity through logs.

@NathanFlurry NathanFlurry marked this pull request as ready for review February 24, 2026 04:00
@NathanFlurry NathanFlurry force-pushed the fix_rivetkit_use_gatewayId_instead_of_requestId_in_connection_persistence_log branch from adb22d7 to fbb6d48 Compare February 24, 2026 04:01
@NathanFlurry NathanFlurry force-pushed the 02-23-chore_rivetkit_fix_sqlite-vfs_for_next-js_cf_workers branch 2 times, most recently from d3be7da to 01476af Compare February 24, 2026 04:12
Base automatically changed from 02-23-chore_rivetkit_fix_sqlite-vfs_for_next-js_cf_workers to main February 24, 2026 04:12
@NathanFlurry NathanFlurry force-pushed the fix_rivetkit_use_gatewayId_instead_of_requestId_in_connection_persistence_log branch from fbb6d48 to 78c338d Compare February 24, 2026 04:13
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4275 February 24, 2026 04:13 Destroyed
@NathanFlurry NathanFlurry merged commit df4fb52 into main Feb 24, 2026
4 of 8 checks passed
@NathanFlurry NathanFlurry deleted the fix_rivetkit_use_gatewayId_instead_of_requestId_in_connection_persistence_log branch February 24, 2026 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant