Skip to content

fix: pkg pr new config#4299

Merged
NathanFlurry merged 3 commits intomainfrom
02-24-fix_pkg_pr_new_config
Feb 26, 2026
Merged

fix: pkg pr new config#4299
NathanFlurry merged 3 commits intomainfrom
02-24-fix_pkg_pr_new_config

Conversation

@jog1t
Copy link
Contributor

@jog1t jog1t commented Feb 24, 2026

Description

Removed the @rivetkit/example-registry package exclusion from the turbo build:publish command in the pkg-pr-new workflow. The build command now includes the example-registry package while still excluding the mcp-hub package.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4299 February 24, 2026 19:32 Destroyed
@jog1t jog1t mentioned this pull request Feb 24, 2026
11 tasks
@railway-app
Copy link

railway-app bot commented Feb 24, 2026

🚅 Deployed to the rivet-pr-4299 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-inspector 😴 Sleeping (View Logs) Web Feb 24, 2026 at 7:42 pm
website 😴 Sleeping (View Logs) Web Feb 24, 2026 at 7:41 pm
frontend-cloud ❌ Build Failed (View Logs) Web Feb 24, 2026 at 7:35 pm
ladle ❌ Build Failed (View Logs) Web Feb 24, 2026 at 7:34 pm
mcp-hub ✅ Success (View Logs) Web Feb 24, 2026 at 7:33 pm

@jog1t jog1t mentioned this pull request Feb 24, 2026
11 tasks
Copy link
Contributor Author

jog1t commented Feb 24, 2026


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Feb 24, 2026

PR Review

Summary: Removes the '!@rivetkit/example-registry' exclusion filter from the turbo build:publish command in the pkg-pr-new CI workflow.


Change Analysis

The change itself is straightforward and appears correct. Searching the repo confirms @rivetkit/example-registry no longer exists as a package — the filter was excluding a package that does not exist, which was dead config. Removing it is a clean-up.

The remaining '!@rivetkit/mcp-hub' exclusion is intentionally kept, which is consistent.


Issues / Suggestions

1. PR description is empty
The PR template checklist has not been filled out. Even for a one-line config change, a brief description of why this was needed (e.g. the example-registry package was removed/renamed and the filter was stale) helps reviewers and future archaeology.

2. Draft status + non-main base branch
The base branch is 02-19-fix_invalid_changelog_ping_position_split rather than main. If that is intentional (stacking on another in-progress branch), that is fine, but worth confirming before merging.

3. No pnpm cache step (pre-existing)
The workflow does not have a pnpm cache step. This predates this change, but a follow-up to add cache: 'pnpm' to the setup-node action would speed up the job.


Verdict

The actual code change is correct and safe. The one-line removal cleans up a stale filter referencing a package that no longer exists. Before merging: fill in the PR description and confirm the base branch target is intentional.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 24, 2026

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4299

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4299

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4299

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4299

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4299

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4299

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4299

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4299

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4299

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4299

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4299

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4299

commit: 2bfbfff

@jog1t jog1t marked this pull request as ready for review February 24, 2026 19:35
Base automatically changed from 02-19-fix_invalid_changelog_ping_position_split to main February 26, 2026 11:20
@NathanFlurry NathanFlurry merged commit 6203ca4 into main Feb 26, 2026
12 of 18 checks passed
@NathanFlurry NathanFlurry deleted the 02-24-fix_pkg_pr_new_config branch February 26, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants