feat: refetch actor details every 5s#4306
feat: refetch actor details every 5s#4306jog1t wants to merge 1 commit into02-24-fix_missing_context_switcher_for_enginefrom
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: feat: refetch actor details every 5sSummary: Single-line change adding CorrectnessThe change is correct. Since the following derived queries all spread from
This is the intended behavior and consistent with how ConsistencyThe interval choice (5000ms) is consistent with:
The base actor list/builds queries use 2000ms, which makes sense since lists change more frequently than individual actor details. Minor Observation (pre-existing, not introduced by this PR)The queryFn: async () => {
return {} as Rivet.Actor; // no throw
},Compare to other stubs: queryFn: async () => {
throw new Error("Not implemented");
// biome-ignore lint/correctness/noUnreachable: stub
return {} as Rivet.Whatever;
},If the default context is ever consumed without being overridden, the silent empty return could produce subtle UI bugs. Not a blocker for this PR since it's pre-existing, but worth aligning in a follow-up. OverallClean, minimal change. No issues introduced. Approved. |
1 participant
Description
Added automatic refetching to actor queries by setting a 5-second refetch interval. This ensures actor data stays up-to-date by polling the server every 5 seconds when the query is active.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: