fix(ups): upgrade nats, fix chunking, add chunking tests#4315
Conversation
|
🚅 Deployed to the rivet-pr-4315 environment in rivet-frontend
|
PR Review: fix(ups): upgrade nats, fix chunking, add chunking testsThis is a solid PR that bundles three distinct fixes. The changes are well-reasoned and the test coverage for the chunking fix is thorough. NATS Upgrade (0.33 → 0.46)The upgrade is clean and the TLS consolidation (removing One minor note: downgrading Chunking Bug Fix (
|
| Area | Assessment |
|---|---|
| NATS upgrade | ✅ Clean migration |
| Event handling | ✅ All new variants handled |
| Chunking fix | ✅ Mathematically correct |
| Tests | ✅ Good coverage, one minor inconsistency to clarify |
| K8s config | ✅ Important reliability fix |
| Test infra | ✅ Clean refactor |
The main thing worth double-checking before merge is the roundtrip vs test_encoded_chunks_with_reply_fit_within_limit inconsistency regarding whether reply subject is included in all chunks or only the first.
dfd219c to
e0b072a
Compare
51558a0 to
165fa47
Compare
e0b072a to
e39972b
Compare
165fa47 to
d33b11b
Compare
d33b11b to
a1e9af4
Compare
e39972b to
409fdf2
Compare
| cluster { | ||
| # Static cluster name. Must be identical across all pods; without it NATS | ||
| # generates a random name on every startup and pods reject each other. | ||
| name: rivet-engine |
There was a problem hiding this comment.
let's update this to include the region. unlikely but good to make sure it never tries to cluster to other dcs.

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: