Skip to content

fix: remove useless config params#4319

Merged
NathanFlurry merged 1 commit intomainfrom
02-26-fix_remove_useless_config_params
Feb 27, 2026
Merged

fix: remove useless config params#4319
NathanFlurry merged 1 commit intomainfrom
02-26-fix_remove_useless_config_params

Conversation

@MasterPtato
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app
Copy link

railway-app bot commented Feb 26, 2026

🚅 Deployed to the rivet-pr-4319 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Feb 27, 2026 at 12:11 am
frontend-inspector 😴 Sleeping (View Logs) Web Feb 26, 2026 at 11:52 pm
frontend-cloud ❌ Build Failed (View Logs) Web Feb 26, 2026 at 8:21 pm
mcp-hub ✅ Success (View Logs) Web Feb 26, 2026 at 8:15 pm
ladle ❌ Build Failed (View Logs) Web Feb 26, 2026 at 8:07 pm

Copy link
Contributor Author

MasterPtato commented Feb 26, 2026

@claude
Copy link

claude bot commented Feb 26, 2026

PR Review: fix: remove useless config params

Good cleanup overall — removing unused/dead config parameters reduces surface area and simplifies configuration. A few follow-up issues worth tracking (PR is already merged):


Bugs / Incomplete Cleanup

1. Schema not updated for the runner_http_max_response_body_sizerunner_max_response_payload_body_size rename

The Rust struct field was renamed in pegboard.rs, but config-schema.json shows no corresponding change (no removal of the old name, no addition of the new name). The schema is out of sync with the Rust struct. Any user setting runner_max_response_payload_body_size in their config will have it silently ignored.

The schema should be regenerated to reflect the rename.

2. Dead field: gateway_http_max_request_body_size has no getter

Pegboard::gateway_http_max_request_body_size still exists as a public struct field and in the config schema, but its getter was removed and it is no longer consumed anywhere. Setting this field in a config file has no effect. Either remove the field entirely or restore enforcement.


Minor Issues

3. Misleading function name for response body limiting

In proxy_service.rs (around line 803–812), the response body buffer limit is enforced using self.state.config.guard().http_max_request_body_size(). This uses a request-body-named getter to limit a response body. While the 20 MiB default is the same right now, the naming will cause confusion if the limits ever need to diverge.

4. Potentially breaking default limit reduction

Guard::http_max_request_body_size default dropped from 256 MiB → 20 MiB, and runner_max_response_payload_body_size dropped from 128 MiB → 20 MiB. These are significant reductions that could silently break actors processing larger payloads. The PR description has the "Breaking change" box unchecked — worth confirming this is intentional and noting it in release notes.


Summary

Issue Severity
Schema not updated for field rename Bug
Dead gateway_http_max_request_body_size field (no getter, not enforced) Incomplete cleanup
http_max_request_body_size() used to limit response body size Minor / confusing naming
Undocumented breaking default limit reduction (256→20 MiB, 128→20 MiB) Worth noting

@MasterPtato MasterPtato force-pushed the 02-26-fix_remove_useless_config_params branch 2 times, most recently from e21bef6 to bc3ad82 Compare February 26, 2026 20:14
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4319 February 26, 2026 20:14 Destroyed
@MasterPtato MasterPtato force-pushed the 02-26-fix_add_serverless_leak_fix_oneoff branch from 8839aa5 to 61a6e04 Compare February 27, 2026 00:12
@MasterPtato MasterPtato force-pushed the 02-26-fix_remove_useless_config_params branch from bc3ad82 to 2f068b7 Compare February 27, 2026 00:12
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 27, 2026

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4319

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4319

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4319

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4319

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4319

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4319

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4319

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4319

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4319

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4319

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4319

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4319

commit: 2f068b7

@NathanFlurry NathanFlurry force-pushed the 02-26-fix_add_serverless_leak_fix_oneoff branch from 61a6e04 to 5f5799b Compare February 27, 2026 00:31
Base automatically changed from 02-26-fix_add_serverless_leak_fix_oneoff to main February 27, 2026 00:31
@NathanFlurry NathanFlurry force-pushed the 02-26-fix_remove_useless_config_params branch from 2f068b7 to 4a2a6ab Compare February 27, 2026 00:31
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4319 February 27, 2026 00:31 Destroyed
@NathanFlurry NathanFlurry merged commit f7d2df2 into main Feb 27, 2026
2 of 6 checks passed
@NathanFlurry NathanFlurry deleted the 02-26-fix_remove_useless_config_params branch February 27, 2026 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants