Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions engine/packages/epoxy/src/ops/propose.rs
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,7 @@ async fn purge_optimistic_cache(ctx: OperationCtx, keys: Vec<String>) -> Result<
.workflow(crate::workflows::purger::Input {
replica_id: dc.datacenter_label as u64,
})
.bypass_signal_from_workflow_I_KNOW_WHAT_IM_DOING()
.tag("replica_id", dc.datacenter_label as u64)
.unique()
.dispatch()
Expand Down
11 changes: 11 additions & 0 deletions engine/packages/gasoline/src/builder/common/workflow.rs
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,17 @@ where
}
}

// TODO: Get rid of this (RVT-5281)
// NOTE: This is a bad implementation because it disregards other errors that may have happened earlier
#[allow(non_snake_case)]
pub fn bypass_signal_from_workflow_I_KNOW_WHAT_IM_DOING(mut self) -> Self {
if let Some(BuilderError::CannotDispatchFromOpInWorkflow) = &self.error {
self.error = None;
}

self
}

pub fn tags(mut self, tags: serde_json::Value) -> Self {
if self.error.is_some() {
return self;
Expand Down
2 changes: 1 addition & 1 deletion engine/packages/guard-core/src/server.rs
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ pub async fn run_server(
tokio::spawn(
async move {
if let Err(err) = conn.await {
tracing::error!("{} connection error: {}", port_type_str, err);
tracing::warn!("{} connection error: {}", port_type_str, err);
}
tracing::debug!("{} connection dropped: {}", port_type_str, remote_addr);

Expand Down
2 changes: 2 additions & 0 deletions engine/packages/pegboard/src/workflows/serverless/receiver.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ pub async fn pegboard_serverless_receiver(ctx: &mut WorkflowCtx, input: &Input)
namespace_id: input.namespace_id,
runner_name: input.runner_name.clone(),
})
.tag("namespace_id", input.namespace_id)
.tag("runner_name", input.runner_name.clone())
.dispatch()
.await?;

Expand Down
3 changes: 2 additions & 1 deletion engine/packages/pools/src/db/ups.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ pub async fn setup(config: &Config, client_name: &str) -> Result<UpsPool> {
tracing::warn!(?server_addrs, "nats draining");
}
async_nats::Event::Closed => {
tracing::error!(?server_addrs, "nats closed");
// Engine is shutting down, not an error
tracing::info!(?server_addrs, "nats closed");
}
async_nats::Event::SlowConsumer(sid) => {
tracing::warn!(?server_addrs, ?sid, "nats slow consumer");
Expand Down
1 change: 1 addition & 0 deletions engine/packages/runtime/src/traces.rs
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ fn build_filter_from_spec(filter_spec: &str) -> anyhow::Result<EnvFilter> {
.add_directive("info".parse()?)
// Disable verbose logs
.add_directive("tokio_cron_scheduler=warn".parse()?)
.add_directive("async_nats=warn".parse()?)
.add_directive("tokio=warn".parse()?)
.add_directive("hyper=warn".parse()?)
.add_directive("h2=warn".parse()?);
Expand Down
Loading