Skip to content

chore: deploy patch#4324

Open
MasterPtato wants to merge 1 commit intomainfrom
02-26-chore_deploy_patch
Open

chore: deploy patch#4324
MasterPtato wants to merge 1 commit intomainfrom
02-26-chore_deploy_patch

Conversation

@MasterPtato
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app
Copy link

railway-app bot commented Feb 27, 2026

🚅 Deployed to the rivet-pr-4324 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Feb 27, 2026 at 3:32 am
ladle ❌ Build Failed (View Logs) Web Feb 27, 2026 at 3:30 am
frontend-inspector 😴 Sleeping (View Logs) Web Feb 27, 2026 at 3:30 am
frontend-cloud 😴 Sleeping (View Logs) Web Feb 27, 2026 at 3:29 am
mcp-hub ✅ Success (View Logs) Web Feb 27, 2026 at 3:19 am

Copy link
Contributor Author

MasterPtato commented Feb 27, 2026


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Feb 27, 2026

PR Review: chore: deploy patch

Summary: Small, focused operational patch covering four areas: a workflow builder escape hatch, an epoxy purge cache fix using that escape hatch, pegboard serverless receiver tag additions, and log level adjustments.


Issues

1. Method name inconsistency on WorkflowBuilder

File: engine/packages/gasoline/src/builder/common/workflow.rs

The method bypass_signal_from_workflow_I_KNOW_WHAT_IM_DOING on WorkflowBuilder has "signal" in the name, but it's actually bypassing the restriction on dispatching workflows from within an operation. The SignalBuilder version makes sense, but the WorkflowBuilder version is misleadingly named. Consider a name like bypass_dispatch_from_workflow_I_KNOW_WHAT_IM_DOING for the WorkflowBuilder variant.

2. Structured logging violation on touched line

File: engine/packages/guard-core/src/server.rs (line 115)

The changed line uses positional format arguments instead of tracing fields:

// Current (violates CLAUDE.md convention)
tracing::warn!("{} connection error: {}", port_type_str, err);

// Should be
tracing::warn!(%err, port_type = %port_type_str, "connection error");

Since this line was actively changed (from error! to warn!), this was an opportunity to fix the structured logging pattern as well. CLAUDE.md explicitly requires: "Do not format parameters into the main message, instead use tracing's structured logging."

3. Pre-existing glob import (not introduced by PR, but worth noting)

File: engine/packages/epoxy/src/ops/propose.rs (line 1)

use anyhow::*;

CLAUDE.md states: "Do not glob import (::*) from anyhow." This wasn't introduced by this PR but the file was modified here.


Minor Notes

  • The bypass escape hatch design is reasonable for a known temporary workaround. The deliberately alarming name, the // TODO: Get rid of this (RVT-5281) comment with a ticket reference, and the inline documentation of why it's a "bad implementation" are all good practices.
  • No tests for the bypass method. The PR checklist acknowledges this. A test verifying the bypass only clears CannotDispatchFromOpInWorkflow (and not other error variants) would prevent regressions when the bypass logic is eventually replaced.
  • Log level adjustments are well-reasoned. The NATS Closedinfo downgrade with the "Engine is shutting down, not an error" comment is clear. The guard connection error errorwarn downgrade is appropriate for edge-level connection drops.
  • Tag additions in pegboard receiver correctly enable workflow lookup and deduplication by namespace_id and runner_name.

Summary

The only actionable item before merge is the structured logging violation on the touched line in guard-core/src/server.rs:115. The method naming inconsistency is minor but worth addressing since the escape hatch is meant to be temporary (so the name won't need to live forever). Everything else is either pre-existing or acceptable.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 27, 2026

More templates

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4324

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4324

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4324

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4324

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4324

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4324

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4324

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4324

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4324

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4324

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4324

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4324

commit: 7f4c3d9

@MasterPtato
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant