Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input target logic for non english languages. #3413

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

karliss
Copy link
Member

@karliss karliss commented Feb 4, 2025

Your checklist for this pull request

Detailed description

Test plan (required)

  • open cutter
  • switch language to non english
  • restart cutter
  • open an executable which reads stdin
  • run a command in console widget, for example ?
  • start debugger and continue
  • run ? in console widget
  • switch input target to debugee input
  • make sure both choices are translated, if not restart the process using different language
  • send input to debugged program
  • switch input target to rizin console
  • run ?

Test program

#include <iostream>

using namespace std;
int main()
{
    int a, b;
    while (std::cin >> a >> b && a > 0) {
        std::cout << a + b << std::endl;
    }
}

Closing issues

Closes #2906

@karliss karliss added BUG Debug Issues related to the Debug component of Cutter labels Feb 4, 2025
@karliss karliss merged commit 287b139 into rizinorg:dev Feb 5, 2025
14 checks passed
@karliss karliss deleted the termi-inp branch February 5, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Debug Issues related to the Debug component of Cutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combobox for input in debugger contain incorrect current selected.
3 participants