Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input target logic for non english languages. #3413

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Fix input target logic for non english languages. #3413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/widgets/ConsoleWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@
# define STDIN_PIPE_NAME "%1/cutter-stdin-%2"
#endif

#define CONSOLE_RIZIN_INPUT ("Rizin Console")
#define CONSOLE_DEBUGEE_INPUT ("Debugee Input")
enum InputTarget { RizinConsole = 0, Debugee = 1 };

static const int invalidHistoryPos = -1;

Expand Down Expand Up @@ -141,7 +140,7 @@ ConsoleWidget::ConsoleWidget(MainWindow *main)
} else {
ui->inputCombo->setVisible(false);
// Return to the rizin console
ui->inputCombo->setCurrentIndex(ui->inputCombo->findText(CONSOLE_RIZIN_INPUT));
ui->inputCombo->setCurrentIndex(InputTarget::RizinConsole);
}
});

Expand Down Expand Up @@ -263,11 +262,11 @@ void ConsoleWidget::sendToStdin(const QString &input)

void ConsoleWidget::onIndexChange()
{
QString console = ui->inputCombo->currentText();
if (console == CONSOLE_DEBUGEE_INPUT) {
int target = ui->inputCombo->currentIndex();
if (target == InputTarget::Debugee) {
ui->rzInputLineEdit->setVisible(false);
ui->debugeeInputLineEdit->setVisible(true);
} else if (console == CONSOLE_RIZIN_INPUT) {
} else if (target == InputTarget::RizinConsole) {
ui->rzInputLineEdit->setVisible(true);
ui->debugeeInputLineEdit->setVisible(false);
}
Expand Down
Loading