Skip to content

fix(canvas): keep unloaded node configs invalid - #2049

Open
K3monn wants to merge 1 commit into
rocketride-org:developfrom
K3monn:fix/RR-2031-openai-node-validation
Open

fix(canvas): keep unloaded node configs invalid#2049
K3monn wants to merge 1 commit into
rocketride-org:developfrom
K3monn:fix/RR-2031-openai-node-validation

Conversation

@K3monn

@K3monn K3monn commented Aug 19, 2026

Copy link
Copy Markdown

Summary

  • Fixed a timing issue where a newly added node could briefly look fully configured before RocketRide had loaded its full config schema.
  • This was especially confusing with the OpenAI node: it could show a valid/white cog and be runnable even though no API key had been set, then fail later with an OpenAI “Missing credentials” error.
  • Nodes now stay invalid while their full schema is loading. Once it loads, the existing form validation checks the required fields normally.

Type

Fix

Testing

  • Tests added or updated
  • Target file passes ESLint
  • git diff --check passes
  • ./builder test passes

Checklist

  • Commit message follows conventional commits
  • No secrets or credentials included
  • Wiki updated (not needed)
  • Breaking changes documented (none)

Linked Issue

Fixes #2031

Summary by CodeRabbit

  • Bug Fixes
    • Improved node configuration validation when service details are unavailable.
    • Nodes based only on catalog summaries now remain unconfigured until their full configuration schema is loaded.
    • Resolved services without configurable fields continue to be treated as valid.

@github-actions

Copy link
Copy Markdown
Contributor
🤖 Internal: Discord sync marker

Auto-managed by the Discord notification workflow. Stores the linked Discord message ID and forum thread ID. Do not edit or delete.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8f57776f-8ddb-42cf-85d5-077a9ca0b3c7

📥 Commits

Reviewing files that changed from the base of the PR and between 1a2a422 and 0c5feaf.

📒 Files selected for processing (1)
  • apps/shared/src/components/canvas/context/FlowGraphContext.tsx

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The canvas now marks nodes as unconfigured when their full service definition is unresolved. Resolved services without configurable fields remain valid.

Changes

Canvas configuration validity

Layer / File(s) Summary
Service resolution validity
apps/shared/src/components/canvas/context/FlowGraphContext.tsx
The validity documentation distinguishes unresolved catalog summaries from resolved services. Missing Pipe instances now produce an invalid configuration state.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 0c5fe

This localized validation fix keeps nodes invalid until their configuration schema is loaded, preventing premature runnable states; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: jmaionchi, rod-christensen, stepmikhaylov

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the fix that keeps unloaded canvas node configurations invalid.
Linked Issues check ✅ Passed The change keeps nodes invalid until service schemas load, which prevents missing OpenAI credentials from appearing valid before execution.
Out of Scope Changes check ✅ Passed The changes are limited to initial node configuration validity and directly support issue #2031.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Canvas OpenAI node: no apikey in config, white cog, runtime “Missing credentials”

1 participant