Skip to content

fix(canvas): keep unloaded node configs invalid #2049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
K3monn wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(canvas): keep unloaded node configs invalid #2049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions apps/shared/src/components/canvas/context/FlowGraphContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,8 +676,9 @@ export function FlowGraphProvider({ children }: IFlowGraphProviderProps): ReactE
* checking whether its service schema requires configuration.
*
* A node requires config when its Pipe schema has properties
* (excluding the hideForm flag). Nodes without schemas or with
* hideForm set are considered valid by default.
* (excluding the hideForm flag). A summary-only catalog entry stays
* invalid until its full schema arrives; fully resolved nodes without
* configurable fields are valid by default.
*
* Matches the logic from the old factory code in factories.ts.
*/
Expand All @@ -687,6 +688,10 @@ export function FlowGraphProvider({ children }: IFlowGraphProviderProps): ReactE
const service = servicesJson?.[data.provider];
if (!service) return true;
const pipe = service.Pipe as { schema?: { properties?: Record<string, unknown> } } | undefined;
// The catalog initially contains summaries only. Until the full
// definition arrives, assume a node needs configuration rather than
// briefly marking it valid and allowing it to run without required fields.
if (!pipe) return false;
return hasConfigurableSchema(pipe) ? false : true;
},
[servicesJson]
Expand Down
Loading