-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IRB 1200 support pkg updates & MoveIt pkgs #85
IRB 1200 support pkg updates & MoveIt pkgs #85
Conversation
Instead of linking, as links tend to go stale.
Do not initialise the database if not requested to for instance.
Opening a PR so Travis can take a look and to (if needed) discuss the proposed changes. |
I just realised that sharing meshes between the Technically no reason those can't be mixed, but aesthetically it's a bit of a no-no. |
Ping! I'd like to see this merged... |
To do this properly I'll need to go and convert meshes to Collada from the meshes that ABB provides. I won't have time for that this week. If you can provide the meshes we are missing, that would expedite things. |
Hi! I'm working with @stwirth on this project. I'm trying to figure out what exactly you need to expedite this. As far as I can tell: Do you just need the 1200_7_70 visual meshes converted from .stl to .dae format, or do you also need some comparison of which ones are equivalent / change in file setup so they can be used together more easily? |
If you're trying to get collada meshes, you can export them directly from robotstudio rather than converting them. Just right click on each link and go "Export Geometry". |
@bhomberg wrote:
It would be nice if we could share as many meshes as possible between the two variants supported by the irb1200 package. Both packages have STL meshes for the collision quality meshes, but the Technically there is nothing preventing us from mixing the two, it just won't look very nice. Summarising: the |
Updated collision meshes to match new visuals. Reuse link_4 from 5_90 with a small (0.1m) offset in x.
More in-line with other support packages.
b5a158a
to
9c84ca2
Compare
I believe this is good to go now. I've requested a review from @Levi-Armstrong. I'll merge after he gives his 👍 |
Thanks @Levi-Armstrong for the review. And thanks @stwirth, @ajshort, @bhomberg and @jonbinney. 🍻 🍔 👍 |
@stwirth, @ajshort, @bhomberg and @jonbinney: I've done a squash-merge in order to avoid repository bloat due to the changes to the various meshes that were tried/created. I've made sure to retain attribution of your contributions in the commit msg of the squash commit. Thanks again. |
Thanks @gavanderhoorn ! |
This includes the changes contributed by @ajshort (in #77) and by @stwirth (in #81), plus a nr of smaller commits by me.
We could also opt to just merge #77 or #81 and fixup things in a subsequent PR, but the reason it might make sense not to do that is that the
7/0.7
variant can share many of its meshes with the5/0.9
. As the7/0.7
variant is introduced in #77 (but doesn't share any meshes with the5/0.9
there), merging that PR would introduce commits that add (relatively) large files to the repository that would then later be removed again.Doing it all in one PR would avoid that (as we can squash merge).