Skip to content

if tf is just a slash "/" resolve should not append "/" #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: noetic-devel
Choose a base branch
from

Conversation

renan028
Copy link

No description provided.

@tfoote
Copy link
Member

tfoote commented Aug 17, 2023

Can you clarify what use case this is effecting? And why you believe that this is the right behavior?

@renan028
Copy link
Author

Can you clarify what use case this is effecting? And why you believe that this is the right behavior?

If the tf_prefix == / and frame == base_link, for instance, I would expect resolve(prefix, frame) to return base_link, but it returns /base_link instead.
Example: https://godbolt.org/z/vzs8x7e7e
This has more than one year, thus I don't remember exact packages, but there are some gazebo packages that expects that (passing tf_prefix as a slash /)

@sloretz
Copy link
Contributor

sloretz commented Apr 23, 2025

Thank you for the PR!

ROS Noetic will reach end-of-life on May 31st, 2025. Every change comes with a risk of introducing regressions, and there isn't much time left to fix them. To make sure this PR doesn't introduce any regressions please:

  • Describe how you tested this change
  • Recruit at least one more person to review this PR and try it out on their system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants