Add robnux_arm_kinematics_trajectory repo.

[guanfengliu]

Please Add This Package to be indexed in the rosdistro.

robnux_arm_kinematics_trajectory

The source is here:

https://github.com/ROBNUX/robnux_arm_kinematics_trajectory.git

Checks

• All packages have a declared license in the package.xml
• This repository has a LICENSE file
• This package is expected to build on the submitted rosdistro

[github-actions]

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

• ROS Distributions are created using REP-134 Standards Track as a guide.
• Your package name should comply to REP-144 ROS Package Naming
• Your package must build for all platforms and architectures on the ROS buildfarm. See REP-2000 ROS Releases and Supported Platforms for all supported platforms for your ROS Distro.
• Your package must contain an OSI approved license. Your package.xml file must also include that license in a machine readable format. See REP-149 Package Manifest Format Three Specification for additional details.
• A publicly available, open source, repository for your ROS package.
• While not required, we recommend that you create an account for ROS Discourse and subscribe to the appropriate release topic.
• If you would like, you may join our Discord Server and ask questions in the #infra-help channel.

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

• REP-2004 Package Quality Declaration-- The ROS 2 TSC has created a quality rating system for ROS packages. These ratings should serve as a guide for package developers. We recommend package developers achieve a quality level of three or higher.
• Documentation -- it is recommended that ROS packages include an extensive README.md file, and API level documentation using the Sphinx documentation system.
• Maintainer Responsibilities -- the ROS 2 documentation includes a guide to ROS package maintainer responsibilities that summarizes your responsibilities as an open source maintainer. While we do not enforce these requirements on package maintainers they should be considered best practices.
• We recommend that your package should strive to conform to the ROS 2 Developer Guide and the ROS 2 Style Guide.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.

---

For changes related to yamllint:

• ✅ All new lines of YAML pass linter checks

[mjcarroll]

Holding for Rolling sync

[guanfengliu]

Don't know why rosdistro validation failed? I generated 1.0.0 release tag in https://github.com/ROBNUX/arm_kinematics_trajectory. But don't know how to retrigger pipeline.

[github-actions]

For changes related to yamllint:

• ✅ All new lines of YAML pass linter checks

[github-actions]

For changes related to yamllint:

• ✅ All new lines of YAML pass linter checks

[Yadunund]

Left comments for rolling. The same applies to noetic.

[github-actions]

For changes related to yamllint:

• ✅ All new lines of YAML pass linter checks

[guanfengliu]

Left comments for rolling. The same applies to noetic.
Addressed. Thanks.

[guanfengliu]

Hmm. still don't know why rosdep checks have errors.

[mjcarroll]

@cottsay can we take a look at why the checks are failing here?

This seems very much unrelated to what is in the PR here.

Error: Package 'clang-native@meta-clang' could not be found for openembedded master on 

Error: Package 'graphviz@meta-ros-common' could not be found for openembedded master on 

[cottsay]

can we take a look at why the checks are failing here?
This seems very much unrelated to what is in the PR here.

Indeed. The old automation is unable to disambiguate between lines being added by a PR, and lines which have been removed on master by commits not present in this PR's history. The new rosdistro-reviewer automation solves the issue, but that check hasn't been moved over to the new automation yet.

Rebasing the PR or merging from master should solve the issue. I'd do it myself, but this PR does not allow write access by rosdistro maintainers.

[MichaelOrlov]

@guanfengliu, Can you please rebase your branch on top of the latest master?
It might help to fix CI warnings.

[github-actions]

For changes related to rosdep:

• ✅ New rosdep keys are named appropriately
• ✅ Platforms for new rosdep rules are valid
• ✅ Installers for new rosdep rules are valid

For changes related to yamllint:

• ✅ All new lines of YAML pass linter checks

[github-actions]

For changes related to yamllint:

• ✅ All new lines of YAML pass linter checks

[MichaelOrlov]

@Yadunund Friendly ping here to re-iterate on review.

[cottsay]

Alright, I was able to take a look at this repository and after discussing with some other developers, I don't believe that this repository is appropriate for inclusion in the official index in its current state. I have two specific points:

1. All of the packages in this repository are catkin packages, so it can't be included in Rolling at all.
2. The names of the individual packages are FAR too broad for inclusion in the official index, and don't accurately describe the scope of each package. For example, a package simply named Logger is simply not appropriate.

The path forward here is to choose more appropriate names for the packages. For reference, here are the packages I found in the repo:

Logger		(ros.catkin)
intp		(ros.catkin)
kdl_common	(ros.catkin)
kinematics_map	(ros.catkin)
quattro		(ros.catkin)
rob_commands	(ros.catkin)
scurve_lib	(ros.catkin)
trajectory	(ros.catkin)

[guanfengliu]

Alright, I was able to take a look at this repository and after discussing with some other developers, I don't believe that this repository is appropriate for inclusion in the official index in its current state. I have two specific points:

1. All of the packages in this repository are `catkin` packages, so it can't be included in Rolling at all.

2. The names of the individual packages are FAR too broad for inclusion in the official index, and don't accurately describe the scope of each package. For example, a package simply named `Logger` is simply not appropriate.

The path forward here is to choose more appropriate names for the packages. For reference, here are the packages I found in the repo:

Logger		(ros.catkin)
intp		(ros.catkin)
kdl_common	(ros.catkin)
kinematics_map	(ros.catkin)
quattro		(ros.catkin)
rob_commands	(ros.catkin)
scurve_lib	(ros.catkin)
trajectory	(ros.catkin)

Hmm, I understand the naming issue of the packages, will modify that. But what is the issue with catkin based package? Doesn't that be aligned with ros convention?

[cottsay]

...what is the issue with catkin based package? Doesn't that be aligned with ros convention?

Catkin-type packages are used in ROS 1, so they're absolutely correct for Noetic. The Rolling distrubtion is ROS 2 which does not use catkin-type packages. Many of the package dependencies are also different, for example, there is no roscpp package in ROS 2.

Your packages need to be ported to ROS 2 before they can be built in a ROS 2 distribution.

[guanfengliu]

...what is the issue with catkin based package? Doesn't that be aligned with ros convention?

Catkin-type packages are used in ROS 1, so they're absolutely correct for Noetic. The Rolling distrubtion is ROS 2 which does not use catkin-type packages. Many of the package dependencies are also different, for example, there is no roscpp package in ROS 2.

Your packages need to be ported to ROS 2 before they can be built in a ROS 2 distribution.

okay. I will remove the changing to rolling. just leave it into noetic

[github-actions]

For changes related to yamllint:

• ✅ All new lines of YAML pass linter checks

[guanfengliu]

(1) changed the naming of each package so that they are more intuitive and matching the scope of the package
(2) revert back the rolling

[guanfengliu]

(1) changed the naming of each package so that they are more intuitive and matching the scope of the package (2) revert back the rolling

Please help to review again.