-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rviz_satellite: 4.1.0-2 in 'jazzy/distribution.yaml' [bloom] #44631
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending a pull request to ROS distro!
This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.
ROS Distro Considerations
- ROS Distributions are created using REP-134 Standards Track as a guide.
- Your package name should comply to REP-144 ROS Package Naming
- Your package must build for all platforms and architectures on the ROS buildfarm. See REP-2000 ROS Releases and Supported Platforms for all supported platforms for your ROS Distro.
- Your package must contain an OSI approved license. Your
package.xml
file must also include that license in a machine readable format. See REP-149 Package Manifest Format Three Specification for additional details. - A publicly available, open source, repository for your ROS package.
- While not required, we recommend that you create an account for ROS Discourse and subscribe to the appropriate release topic.
- If you would like, you may join our Discord Server and ask questions in the
#infra-help
channel.
Package Considerations
Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.
- REP-2004 Package Quality Declaration-- The ROS 2 TSC has created a quality rating system for ROS packages. These ratings should serve as a guide for package developers. We recommend package developers achieve a quality level of three or higher.
- Documentation -- it is recommended that ROS packages include an extensive README.md file, and API level documentation using the Sphinx documentation system.
- Maintainer Responsibilities -- the ROS 2 documentation includes a guide to ROS package maintainer responsibilities that summarizes your responsibilities as an open source maintainer. While we do not enforce these requirements on package maintainers they should be considered best practices.
- We recommend that your package should strive to conform to the ROS 2 Developer Guide and the ROS 2 Style Guide.
Need Help?
Please post your questions to Robotics Stack Exchange or refer to the #infra-help
channel on our Discord server.
For changes related to yamllint:
- ✅ All new lines of YAML pass linter checks
Hey there, automated guardian of ROS standards! Thanks for the thorough (and, might I say, impressively detailed) checklist. Rest assured, this package checks all the right boxes. The name follows the sacred scrolls of REP-144, it builds successfully on all the officially blessed platforms per REP-2000, and it comes bearing an OSI-approved license, neatly declared in package.xml, because who doesn’t love a good machine-readable legal statement? The source repository is publicly available and open-source, as any good ROS package should be. It also includes documentation because I know better than to make future me (or anyone else) struggle to figure out what’s going on six months from now. Plus, it aligns with the ROS 2 Developer and Style Guides—because while chaos is fun, structured chaos is even better. As for package quality, it follows REP-2004, aiming for at least a level 3 badge of honor. I’ve have not reviewed the package maintainer responsibilities, which means I solemnly swear to fix things when they break (or at least stare at them with deep concern before doing so). So, all should be in order for review and merge. If anything is missing, I’m happy to adjust. Otherwise, let’s get this show on the road! 🚀 Please note, the above was (of course) also generated. Who doesn't love machines talking to each other :). |
Increasing version of package(s) in repository
rviz_satellite
to4.1.0-2
:jazzy/distribution.yaml
0.12.0
4.1.0-1
rviz_satellite