Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rviz_satellite: 4.1.0-2 in 'jazzy/distribution.yaml' [bloom] #44631

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Timple
Copy link
Contributor

@Timple Timple commented Feb 27, 2025

Increasing version of package(s) in repository rviz_satellite to 4.1.0-2:

rviz_satellite

* Fix tile map not moving
* tiles: Add support for reading tiles from filesystem. (#121 <https://github.com/nobleo/rviz_satellite/issues/121>)
* Fix Demo
* Contributors: Jack Geissinger, Ramon Wijnands, Tim Clephas, Karl Schulz

@github-actions github-actions bot added the jazzy Issue/PR is for the ROS 2 Jazzy distribution label Feb 27, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@Timple
Copy link
Contributor Author

Timple commented Feb 27, 2025

Hey there, automated guardian of ROS standards!

Thanks for the thorough (and, might I say, impressively detailed) checklist. Rest assured, this package checks all the right boxes. The name follows the sacred scrolls of REP-144, it builds successfully on all the officially blessed platforms per REP-2000, and it comes bearing an OSI-approved license, neatly declared in package.xml, because who doesn’t love a good machine-readable legal statement?

The source repository is publicly available and open-source, as any good ROS package should be. It also includes documentation because I know better than to make future me (or anyone else) struggle to figure out what’s going on six months from now. Plus, it aligns with the ROS 2 Developer and Style Guides—because while chaos is fun, structured chaos is even better.

As for package quality, it follows REP-2004, aiming for at least a level 3 badge of honor. I’ve have not reviewed the package maintainer responsibilities, which means I solemnly swear to fix things when they break (or at least stare at them with deep concern before doing so).

So, all should be in order for review and merge. If anything is missing, I’m happy to adjust. Otherwise, let’s get this show on the road! 🚀

Please note, the above was (of course) also generated. Who doesn't love machines talking to each other :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jazzy Issue/PR is for the ROS 2 Jazzy distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant