Skip to content

Other Logging Implementations with getLevelNamesMapping fix #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 30, 2025
Merged

Other Logging Implementations with getLevelNamesMapping fix #866

merged 9 commits into from
Apr 30, 2025

Conversation

InvincibleRMC
Copy link
Contributor

Redo of #858

With fix.

InvincibleRMC and others added 7 commits April 12, 2025 23:14
@InvincibleRMC
Add other logging implementations
d520596 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Merge branch 'ros2:rolling' into add-generic-log-implementation
b28e2de
@InvincibleRMC
Address feedback
cbb54ce 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC @christophebedard
Update launch/launch/actions/log_info.py
2e73659 
Co-authored-by: Christophe Bedard <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Use pytest.raises
b5cad75 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Fix level_error test
eadc495 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Add version check
da727d2 
Signed-off-by: Michael Carlstrom <[email protected]>
@christophebedard christophebedard self-requested a review April 28, 2025 23:24
@christophebedard
Copy link
Member

Can you rebase on rolling?

christophebedard
christophebedard approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR (again) and for making the fix!

Now I'll trigger CI and triple-check 😆

@christophebedard
Copy link
Member

christophebedard commented Apr 29, 2025 •
edited
Loading

Pulls: #866
Gist: https://gist.githubusercontent.com/christophebedard/45312c1e520537aae1aebfc9f7e490b1/raw/6f35f009047a5ffc1577a49c27074f1c4e1213e1/ros2.repos
BUILD args: --packages-above-and-dependencies launch launch_xml launch_yaml
TEST args: --packages-above launch launch_xml launch_yaml
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15820

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@christophebedard
Copy link
Member

Alright, CI looks good. The test failures are unrelated.

@christophebedard christophebedard merged commit f580507 into ros2:rolling Apr 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophebedard christophebedard christophebedard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@InvincibleRMC @christophebedard