fix: respect Retry-After headers and MCP rate-limit signals in sync s…#556
Open
sskninja wants to merge 1 commit into
Open
fix: respect Retry-After headers and MCP rate-limit signals in sync s…#556sskninja wants to merge 1 commit into
sskninja wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhanced Rate-Limit Parsing:
Granola: Added logic to apiCall to parse the Retry-After HTTP header (supporting both integer seconds and Date formats) and throw a dedicated RateLimitError.
Fireflies: Updated callWithRateLimit to detect MCP error objects containing a data.retryAfter property.
Accurate Backoff Execution:
Modified the retry logic in both services to prioritize the server-suggested delay over the local default, ensuring the backend respects exact backoff requirements.
Build System Fixes:
Updated pnpm-workspace.yaml to explicitly allow build scripts for core dependencies (electron, esbuild, etc.), resolving build failures in clean environments.
Corrected the esbuild execution path in apps/preload/package.json to call the binary directly, bypassing broken local shims.