Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support config extends #561

Closed

Conversation

brettlangdon
Copy link
Contributor

I was looking to create a common .sass-lint.yml config that I could use across different projects easily, similar to ESLint.

I noticed in #400 that there was mention of supporting plugins similar to ESLint. This isn't really support for plugins, more specific for defining common styles in a separate package, but there is potentially some overlap between the two goals.

I am content if this isn't the approach that we want to take here, I just figured I'd take an initial stab at it.

DCO 1.1 Signed-off-by: Brett Langdon [email protected]

@brettlangdon
Copy link
Contributor Author

I have created https://github.com/underdogio/sass-lint-underdog which is a wrapper around sass-lint, which loads in a default configuration file first before linting. It isn't very pretty, but I wanted to share this here in case anyone was interested in trying to have support for default/shareable sass-lint configs in the meantime.

@DanPurdy
Copy link
Member

DanPurdy commented Apr 5, 2016

Hi @brettlangdon sorry for the silence around this! Thanks for your PR, we've just updated develop with all of the rule updates and features etc for our impending 1.6 release would you mind updating this PR and then we can definitely look over it for you.

Thanks again for your PR 👍

@brettlangdon brettlangdon force-pushed the support-config-extends branch from 634d8ca to 721ab2e Compare April 5, 2016 13:03
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 96.818% when pulling 721ab2e on underdogio:support-config-extends into db4db51 on sasstools:develop.

@brettlangdon
Copy link
Contributor Author

@DanPurdy are double quotes a new standard? Should I update my code to use double quotes?

@DanPurdy
Copy link
Member

DanPurdy commented Apr 5, 2016

@brettlangdon no dont worry about it @Snugug just needs to update our settings in codacy or remove it 😉

Leave them as single quotes for now, thanks! We'll look into this now it's updated! Thanks! 👍

@DanPurdy DanPurdy mentioned this pull request Aug 23, 2016
4 tasks
@aapokiiso
Copy link

@DanPurdy Hi! Any chance to look into this PR again? We'd love to be able to create a shared sass-lint config, which could then be extended in projects.

@artiomnist
Copy link

@DanPurdy Is anyone looking to this? Need any help?

I'd really like to be able to have a shareable/extendable sass-lint config!

@aapokiiso
Copy link

@artiomnist Forgot to update my reply, but it actually works already! You can configure your .sasslintrc like this:

{
    "options": {
        "config-file": "node_modules/@companyname/sasslint-config/.sasslintrc"
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants