Skip to content

Conversation

BourgoisMickael
Copy link
Contributor

@BourgoisMickael BourgoisMickael commented Aug 14, 2025

To be able to run backbeat routes test in Integration as it was before (in branch 7.70).

@bert-e
Copy link
Contributor

bert-e commented Aug 14, 2025

Hello bourgoismickael,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

Copy link

codecov bot commented Aug 14, 2025

❌ 19 Tests Failed:

Tests completed Failed Passed Skipped
20659 19 20640 0
View the top 3 failed test(s) by shortest run time
should accept valid versioning configuration if user is a replication user::aws-node-sdk test bucket versioning should accept valid versioning configuration if user is a replication user
Stack Traces | 0.003s run time
Access Denied
"before each" hook for "should be 'PENDING' when object key prefix applies"::Head object 'ReplicationStatus' value With v4 signature With bucket replication config "before each" hook for "should be 'PENDING' when object key prefix applies"
Stack Traces | 0.004s run time
Invalid Role specified in replication configuration: Role must be a comma-separated list of two IAM roles
"before each" hook for "should be 'PENDING' when object key prefix applies"::Head object 'ReplicationStatus' value With default signature With bucket replication config "before each" hook for "should be 'PENDING' when object key prefix applies"
Stack Traces | 0.005s run time
Invalid Role specified in replication configuration: Role must be a comma-separated list of two IAM roles

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@bert-e
Copy link
Contributor

bert-e commented Aug 14, 2025

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@BourgoisMickael BourgoisMickael marked this pull request as ready for review August 14, 2025 14:48
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR unifies test backbeat routes by refactoring backbeat replication tests to support both same-account and cross-account scenarios while adding S3C test environment support.

  • Parameterizes existing replication tests to run in both same-account and cross-account scenarios
  • Adds S3C environment support with appropriate test skipping logic
  • Consolidates replication test execution under a unified test script

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/multipleBackend/routes/routeBackbeatForReplication.js Parameterizes replication tests for same/cross-account scenarios and adds S3C support
tests/multipleBackend/routes/routeBackbeat.js Adds S3C test skipping logic and updates authorization tests with proper credentials
tests/functional/aws-node-sdk/test/multipleBackend/utils.js Adds safety checks for missing location constraints
tests/functional/aws-node-sdk/lib/utility/test-utils.js Adds S3C and AWS test environment detection utilities
package.json Updates test script to run unified backbeat route tests
lib/routes/routeBackbeat.js Adds content length parsing for request monitoring

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@BourgoisMickael BourgoisMickael force-pushed the improvement/CLDSRV-717-unify-test-backbeat-route branch from 7902916 to 8a004c1 Compare August 14, 2025 15:01
@BourgoisMickael BourgoisMickael changed the title CLDSRV-717: Unify test backbeat route CLDSRV-717: Unify tests backbeat route Aug 14, 2025
@BourgoisMickael BourgoisMickael requested review from williamlardier and a team August 18, 2025 13:32
Comment on lines 1540 to 1553
queryObj: {
versionId: versionIdUtils.encode(testMd.versionId),
},
authCredentials: backbeatAuthCredentials,
Copy link
Contributor

@francoisferrand francoisferrand Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this extra parameter?
this was not required before (at least in Zenko), why do we need to pass it?

  • Here, it seems the tests are about creating a new version automatically, so the caller (practically, that would be backbeat) should not provide a versionID; if we have another feature where we can create an object with a specific VersionID, that should be a separate test (if not already implemented)
  • If this parameter is actually required (even for Zenko!) -even though maybe the tests did not see the issue- then we are missing some validation in the API

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(same applies to a few other tests below)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not required, I removed it.

It came from branch 7.70 where the test did not create new version but updated the same versionId

"ft_node": "cd tests/functional/raw-node && yarn test",
"ft_node_routes": "cd tests/functional/raw-node && yarn run test-routes",
"ft_node_route_backbeat": "cd tests/functional/raw-node && mocha --reporter mocha-multi-reporters --reporter-options configFile=$INIT_CWD/tests/reporter-config.json -t 40000 test/routes/routeBackbeat.js --exit",
"ft_route_backbeat": "cd tests/multipleBackend/routes && mocha --reporter mocha-multi-reporters --reporter-options configFile=$INIT_CWD/tests/reporter-config.json -t 40000 routeBackbeat.js routeBackbeatForReplication.js --exit",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kind of duplicates multiple_backend_test script?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this only picks backbeat route tests without veeam route and other multiple backend tests, as it was executing in ft_node_routes before in 7.70

@BourgoisMickael BourgoisMickael force-pushed the improvement/CLDSRV-717-unify-test-backbeat-route branch from 4d63583 to da2cb20 Compare August 25, 2025 17:36
@BourgoisMickael BourgoisMickael force-pushed the improvement/CLDSRV-717-unify-test-backbeat-route branch from 416d355 to 4c73202 Compare August 27, 2025 10:24
Because it doesn't go through arsenal's normalizeRequest.
Do the same as for veeam route, to have the log field bytesReceived
@BourgoisMickael BourgoisMickael force-pushed the improvement/CLDSRV-717-unify-test-backbeat-route branch from 4c73202 to 0bd3d47 Compare August 27, 2025 10:27
@BourgoisMickael BourgoisMickael force-pushed the improvement/CLDSRV-717-unify-test-backbeat-route branch from 0bd3d47 to 4e4f7ff Compare August 27, 2025 11:37
@BourgoisMickael
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Aug 28, 2025

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Aug 28, 2025

Build failed

The build for commit did not succeed in branch w/9.1/improvement/CLDSRV-717-unify-test-backbeat-route

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Aug 28, 2025

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/9.0

  • ✔️ development/9.1

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Aug 28, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.0

  • ✔️ development/9.1

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8

Please check the status of the associated issue CLDSRV-717.

Goodbye bourgoismickael.

@bert-e bert-e merged commit bf9e99f into development/9.0 Aug 28, 2025
28 checks passed
@bert-e bert-e deleted the improvement/CLDSRV-717-unify-test-backbeat-route branch August 28, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants