CLDSRV-717: Unify test routeBackbeatForReplication #5919

BourgoisMickael · 2025-08-26T16:33:14Z

Split from #5907 to simplify review

You can review by commit.

The skip will be removed completely by CLDSRV-632

S3C branches used to tests in the same account. There was no Replication account. See: https://github.com/scality/cloudserver/blob/development/7.70/tests/functional/raw-node/test/routes/routeBackbeatForReplication.js

bert-e · 2025-08-26T16:33:18Z

Hello bourgoismickael,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2025-08-26T16:33:24Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

codecov · 2025-08-26T16:34:11Z

❌ 17 Tests Failed:

Tests completed	Failed	Passed	Skipped
20611	17	20594	0

View the top 3 failed test(s) by shortest run time

should accept valid versioning configuration if user is a replication user::aws-node-sdk test bucket versioning should accept valid versioning configuration if user is a replication user

Stack Traces | 0.003s run time

Access Denied

"after each" hook for "should overwrite an object"::PUT object with x-scal-s3-version-id header With v4 signature "after each" hook for "should overwrite an object"

Stack Traces | 0.005s run time

The specified bucket does not exist.

"before each" hook for "should be 'PENDING' when object key prefix applies"::Head object 'ReplicationStatus' value With default signature With bucket replication config "before each" hook for "should be 'PENDING' when object key prefix applies"

Stack Traces | 0.005s run time

Invalid Role specified in replication configuration: Role must be a comma-separated list of two IAM roles

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

Copilot

Pull Request Overview

This PR refactors test code to unify the routeBackbeatForReplication test by introducing support for both same-account and cross-account replication scenarios. The changes eliminate code duplication and make the tests more maintainable.

Extracts common logic into reusable functions and configuration objects
Adds scenario-based testing to support both same-account and cross-account replication
Consolidates repetitive object metadata handling code

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

tests/multipleBackend/routes/routeBackbeatForReplication.js

williamlardier · 2025-08-27T06:29:56Z

tests/multipleBackend/routes/routeBackbeatForReplication.js

                objectKey: keyName,
                queryObj: { versionId: 'null' },
-                authCredentials: destinationAuthCredentials,
+                authCredentials: sourceAuthCredentials,


Why this change? It looks like we are on purpose getting the replicated null version as per the step name

The bucket is bucketSource, not bucketDestination

And I get an Access Denied when testing with S3C

And the PUT into the bucketDestination is done below. If I try a GET on that bucket I get an ObjNotFound.

Now I think maybe we did not get any error in a zenko context because the replication credentials are using the zenko replication service account that can access every resources ?

I've describe the test phases and renamed the steps to be clearer: 4e067fd

The GET is done on the source to retrieve the object after lifecycle before replicating it to destination.

So the source credentials should be used on the source bucket

Step names were unclear

BourgoisMickael · 2025-08-27T09:42:33Z

/create_integration_branches

bert-e · 2025-08-27T09:42:43Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/CLDSRV-717-unify-test-bbreplication into
development/9.0
w/9.1/improvement/CLDSRV-717-unify-test-bbreplication will be merged into development/9.1

The following branches will NOT be impacted:

development/7.10
development/7.4
development/7.70
development/8.8

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

bert-e · 2025-08-27T09:42:44Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

BourgoisMickael · 2025-08-28T16:44:27Z

/approve

bert-e · 2025-08-28T16:44:43Z

Build failed

The build for commit did not succeed in branch w/9.1/improvement/CLDSRV-717-unify-test-bbreplication

The following options are set: approve, create_integration_branches

bert-e · 2025-08-28T17:09:04Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/9.0
✔️ development/9.1

The following branches will NOT be impacted:

development/7.10
development/7.4
development/7.70
development/8.8

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve, create_integration_branches

bert-e · 2025-08-28T17:14:02Z

Queue build failed

The corresponding build for the queue failed:

Checkout the status page.
Identify the failing build and review the logs.
If no issue is found, re-run the build.
If an issue is identified, checkout the steps below to remove
the pull request from the queue for further analysis and maybe rebase/merge.

Remove the pull request from the queue

Add a /wait comment on this pull request.
Click on login on the status page.
Go into the manage page.
Find the option called Rebuild the queue and click on it.
Bert-E will loop again on all pull requests to put the valid ones
in the queue again, while skipping the one with the /wait comment.
Wait for the new queue to merge, then merge/rebase your pull request
with the latest changes to then work on a proper fix.
Once the issue is fixed, delete the /wait comment and
follow the usual process to merge the pull request.

bert-e · 2025-08-28T18:11:45Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/9.0
✔️ development/9.1

The following branches have NOT changed:

development/7.10
development/7.4
development/7.70
development/8.8

Please check the status of the associated issue CLDSRV-717.

Goodbye bourgoismickael.

BourgoisMickael added 5 commits August 26, 2025 18:29

CLDSRV-717: Factorize accountInfo update in MD

c181b18

CLDSRV-717: Fix creds for request to bucketSource

c08a4d4

CLDSRV-717: Unskip some replication tests for S3C

4fe211c

The skip will be removed completely by CLDSRV-632

CLDSRV-717: Change accountId to work with Vault 1

1f27fe8

CLDSRV-717: Reintroduce same account tests

13648a5

S3C branches used to tests in the same account. There was no Replication account. See: https://github.com/scality/cloudserver/blob/development/7.70/tests/functional/raw-node/test/routes/routeBackbeatForReplication.js

BourgoisMickael requested a review from Copilot August 26, 2025 16:33

Copilot AI reviewed Aug 26, 2025

View reviewed changes

tests/multipleBackend/routes/routeBackbeatForReplication.js Show resolved Hide resolved

tests/multipleBackend/routes/routeBackbeatForReplication.js Show resolved Hide resolved

tests/multipleBackend/routes/routeBackbeatForReplication.js Show resolved Hide resolved

BourgoisMickael mentioned this pull request Aug 26, 2025

CLDSRV-717: Unify tests backbeat route #5907

Merged

BourgoisMickael requested review from a team, Kerkesni, francoisferrand and williamlardier August 26, 2025 17:27

jonathan-gramain approved these changes Aug 26, 2025

View reviewed changes

williamlardier reviewed Aug 27, 2025

View reviewed changes

CLDSRV-717: Describe test lifecycled replication

4e067fd

Step names were unclear

BourgoisMickael requested a review from williamlardier August 27, 2025 09:38

BourgoisMickael requested a review from a team August 27, 2025 14:56

tcarmet approved these changes Aug 27, 2025

View reviewed changes

bert-e merged commit d61f966 into development/9.0 Aug 28, 2025
28 checks passed

bert-e deleted the improvement/CLDSRV-717-unify-test-bbreplication branch August 28, 2025 18:11

CLDSRV-717: Unify test routeBackbeatForReplication #5919

CLDSRV-717: Unify test routeBackbeatForReplication #5919

Conversation

BourgoisMickael commented Aug 26, 2025

Uh oh!

bert-e commented Aug 26, 2025

Hello bourgoismickael,

Uh oh!

bert-e commented Aug 26, 2025

Request integration branches

Uh oh!

codecov bot commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 17 Tests Failed:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

williamlardier Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

BourgoisMickael Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

BourgoisMickael Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

BourgoisMickael Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

BourgoisMickael Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

BourgoisMickael commented Aug 27, 2025

Uh oh!

bert-e commented Aug 27, 2025

Integration data created

Uh oh!

bert-e commented Aug 27, 2025

Waiting for approval

Uh oh!

BourgoisMickael commented Aug 28, 2025

Uh oh!

bert-e commented Aug 28, 2025

Build failed

Uh oh!

bert-e commented Aug 28, 2025

In the queue

Uh oh!

bert-e commented Aug 28, 2025

Queue build failed

Uh oh!

bert-e commented Aug 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Aug 26, 2025 •

edited

Loading