Container pytests #346
Merged
Container pytests #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request validationFailed🔴 Failed or pending statuses:
🔴 Review - Missing review from a member (1 required) |
Testing Farm results
|
phracek
force-pushed
the
container_pytests
branch
from
fb343d5 to
46bd6dc
Compare
Member
Author
|
Let's try first round of tests. RHEL9 and version 5.32 passed [test-pytest] |
Member
Author
|
This has to be reviewed as from Perl Container point of view as from Python point of view. So 2 approvals are needed. |
phracek
requested review from
befeleme,
frenzymadness,
jplesnik and
michal-josef-spacek
Member
|
Before I do a review here, could you please take a look at: sclorg/s2i-python-container#759 You might like some of the improvements I've proposed for Python container and they might be implemented here as well. |
phracek
force-pushed
the
container_pytests
branch
2 times, most recently
from
8cb6839 to
9eee22a
Compare
Signed-off-by: Petr "Stone" Hracek <[email protected]>
as is mentioned in test/run script.
New test files are added:
test/run-pytest .. that runs PyTest alone
test/test_container_basics.py
test/test_container_s2i.py
All files are added as symlinks to each version.
Migration matrix is:
test_sample_test_app -> test_container_s2i.py class TestPerlSampleTestAppContainer
test_binpath -> test_container_s2i.py parametrized TestPerlExampleAppContainer
test_psgi -> test_container_s2i.py parametrized TestPerlExampleAppContainer
test_fcgi -> test_container_s2i.py parametrized TestPerlExampleAppContainer
test_psgi_variables -> test_container_s2i.py parametrized TestPerlExampleAppContainer
test_warningonstderr -> test_container_s2i.py parametrized TestPerlExampleAppContainer
test_psgi_hot_deploy_without_reload -> test_container_s2i.py parametrized TestPerlHotDeployAppContainer
test_psgi_hot_deploy_with_reload -> test_container_s2i.py parametrized TestPerlHotDeployAppContainer
test_npm -> test_container_s2i.py parametrized TestPerlNPMtestContainer
test_from_dockerfile -> test_container_basics.py class TestPerlContainer
test_scl_usage -> test_container_basics.py class TestPerlContainer
test_docker_run_usage -> test_container_basics.py class TestPerlContainer
test_run_s2i_usage -> test_container_basics.py class TestPerContainer
Signed-off-by: Petr "Stone" Hracek <[email protected]>
./run-pytest ./test_container_basics.py ./test_container_s2i.py ./conftest.py Signed-off-by: Petr "Stone" Hracek <[email protected]>
phracek
force-pushed
the
container_pytests
branch
from
9eee22a to
1aa7537
Compare
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Member
Author
|
Re-written like it is done in sclorg/s2i-python-container#759 Let's test it |
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Member
Author
|
@frenzymadness The tests have been rewritten based on your small improvements in s2i-python-container. So PTAL. Not urgent. |
Member
frenzymadness
left a comment
frenzymadness
left a comment
There was a problem hiding this comment.
Overall, it looks very good to me. Just a few minor comments.
what we tests. Add description, why sleep(3) is present in HotPlug test Signed-off-by: Petr "Stone" Hracek <[email protected]>
phracek
force-pushed
the
container_pytests
branch
from
f8d42b1 to
3491af1
Compare
Signed-off-by: Petr "Stone" Hracek <[email protected]>
Member
Author
|
[test-pytest][test-openshift] |
frenzymadness
approved these changes
Oct 17, 2025
Member
frenzymadness
left a comment
frenzymadness
left a comment
There was a problem hiding this comment.
I skimmed through it again, and it looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for testing container by PyTest suite.
New test files are added:
All files are added as symlinks to each version.
Migration matrix is:
test_sample_test_app->test_container_s2i.pyclass TestPerlSampleTestAppContainertest_binpath->test_container_s2i.pyparametrized TestPerlExampleAppContainertest_psgi->test_container_s2i.pyparametrized TestPerlExampleAppContainertest_fcgi->test_container_s2i.pyparametrized TestPerlExampleAppContainertest_psgi_variables->test_container_s2i.pyparametrized TestPerlExampleAppContainertest_warningonstderr->test_container_s2i.pyparametrized TestPerlExampleAppContainertest_psgi_hot_deploy_without_reload->test_container_s2i.pyparametrized TestPerlHotDeployAppContainertest_psgi_hot_deploy_with_reload->test_container_s2i.pyparametrized TestPerlHotDeployAppContainertest_npm->test_container_s2i.pyparametrized TestPerlNPMtestContainertest_from_dockerfile->test_container_basics.pyclass TestPerlContainertest_scl_usage->test_container_basics.pyclass TestPerlContainertest_docker_run_usage->test_container_basics.pyclass TestPerlContainertest_run_s2i_usage->test_container_basics.pyclass TestPerContainer