framework: return error instead of panicking on out-of-range array index#204
Open
c-tonneslan wants to merge 1 commit into
Open
framework: return error instead of panicking on out-of-range array index#204c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
overridePathInArray bounds-checked the index only in the terminal (len(path) == 1) branch. When the override path continued past the index it indexed output[pathIndex] directly, so an override like volumes.3.source against a shorter array panicked with "index out of range". Return the same out-of-range error the terminal branch already returns. Fixes score-spec#202 Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
mathieu-benoit
self-requested a review
July 6, 2026 22:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
overridePathInArrayonly bounds-checks the array index in the terminal (len(path) == 1) branch. When the override path continues past the index, it falls through tooutput[pathIndex]with no check, so an override such asvolumes.3.sourceagainst a shorter array panics withindex out of range(a negative index likevolumes.-1.sourcepanics too). Since--override-propertyvalues flow straight intoOverridePathInMap, a typo'd index crashes the CLIs with a Go stack trace instead of the usual friendly error.This adds the same out-of-range check the terminal branch already returns, before the type switch. Added two table cases (
nested index out of range,nested negative index) that panic on main and now returncannot set 'N' in array: out of range.Fixes #202