Skip to content

framework: return error instead of panicking on out-of-range array index #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
c-tonneslan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

framework: return error instead of panicking on out-of-range array index #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions framework/override_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,10 @@ func overridePathInArray(input []interface{}, path []string, isDelete bool, valu
return output, nil
}

if pathIndex < 0 || pathIndex >= len(output) {
return nil, fmt.Errorf("cannot set '%d' in array: out of range", pathIndex)
}

switch typed := output[pathIndex].(type) {
case map[string]interface{}:
subOutput, err := overridePathInMap(typed, path[1:], isDelete, value)
Expand Down
14 changes: 14 additions & 0 deletions framework/override_utils_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,20 @@ func TestWritePathInStruct(t *testing.T) {
Value: "hello",
ExpectedError: fmt.Errorf("a: cannot set '2' in array: out of range"),
},
{
Name: "nested index out of range",
Spec: `{"a": [{}]}`,
Path: []string{"a", "2", "c"},
Value: "hello",
ExpectedError: fmt.Errorf("a: cannot set '2' in array: out of range"),
},
{
Name: "nested negative index",
Spec: `{"a": [{}]}`,
Path: []string{"a", "-1", "c"},
Value: "hello",
ExpectedError: fmt.Errorf("a: cannot set '-1' in array: out of range"),
},
{
Name: "no append nested arrays",
Spec: `{"a":[[0]]}`,
Expand Down