Skip to content

Conversation

@mfaferek93
Copy link
Collaborator

@mfaferek93 mfaferek93 commented Nov 22, 2025

[#11] feat: Establish discovery system and add support for /areas network endpoint

  • new endpoint GET /areas
  • Discovery manager for ROS 2 nodes/namespaces
  • demo automotive nodes in proper namespaces
  • integration tests + postman configuration files
  • Configuration, launch files, documentation

Pull Request

Description

What changed and why.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Related issues

Fixes # (if applicable)
Related to # (if applicable)

How has this been tested?

Describe the tests you ran to verify your changes.

Checklist

  • My code follows the project's coding style
  • I ran colcon build and the build succeeds without warnings
  • I ran colcon test and all tests pass locally
  • I added/updated tests where applicable
  • I updated documentation where applicable
  • My commit messages are clear and descriptive

Additional notes for reviewers

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request establishes a discovery system for ROS 2 nodes and namespaces, introducing the GET /areas REST API endpoint. The gateway automatically discovers nodes in the ROS 2 system, organizes them into areas based on their namespace hierarchy, and exposes this information through a RESTful HTTP interface.

Key Changes:

  • Implemented DiscoveryManager to discover and organize ROS 2 nodes into areas and components
  • Added GET /areas endpoint to list discovered areas (e.g., powertrain, chassis, body)
  • Created demo automotive nodes in proper namespaces for testing
  • Added comprehensive integration tests and Postman collections

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/gateway_node.cpp Refactored from monolithic implementation to modular architecture with discovery and REST server managers
src/rest_server.cpp New REST server implementation with /health, /, and /areas endpoints
src/discovery_manager.cpp New discovery system that extracts areas from ROS 2 node namespaces
include/ros2_medkit_gateway/*.hpp Header files defining gateway architecture with thread-safe entity cache
test/test_integration.test.py Integration tests verifying area discovery and REST API functionality
test/demo_nodes/*.cpp Seven demo automotive nodes simulating sensors, actuators, and services
launch/gateway.launch.py Launch file with configurable parameters for gateway server
launch/demo_nodes.launch.py Launch file organizing demo nodes into automotive areas
config/gateway_params.yaml Configuration file with server and cache refresh parameters
CMakeLists.txt Build configuration for gateway, demo nodes, and integration tests
package.xml Updated dependencies for new functionality
README.md Comprehensive documentation of features, configuration, and usage
postman/* Postman collection and environment for manual API testing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mfaferek93 mfaferek93 force-pushed the 11/feat/GET/areas branch 2 times, most recently from a83fb1c to 297dd2b Compare November 22, 2025 17:38
@mfaferek93 mfaferek93 requested a review from bburda November 22, 2025 18:18
…areas network endpoint

- new endpoint GET /areas
- Discovery manager for ROS 2 nodes/namespaces
- demo automotive nodes in proper namespaces
- integration tests + postman configuration files
- Configuration, launch files, documentation
- plantum class diagrams
Copy link
Collaborator

@bburda bburda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bburda bburda merged commit f1f326d into selfpatch:main Nov 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Establish discovery system and add support for /areas network endpoint.

2 participants