fix(fault_manager): allow CLEARED faults to be reactivated by FAILED …

[mfaferek93]

Pull Request

Summary

allow CLEARED faults to be reactivated by FAILED events

Previously, report_fault_event() had an early return that silently
ignored all events for CLEARED faults. This caused faults to remain
CLEARED forever even when the underlying issue recurred.

Changes:

• FAILED events now reactivate CLEARED faults with debounce counter
  reset to -1 (fresh start)
• PASSED events for CLEARED faults are still ignored (expected)
• occurrence_count increments on reactivation
• Return true to trigger EVENT_CONFIRMED and snapshot capture

Updated tests to reflect new behavior and added integration test.

---

Issue

Link the related issue (required):

• closes [BUG] FaultManager ignores new FAILED reports after a fault was CLEARED #144

---

Type

• Bug fix
• New feature or tests
• Breaking change
• Documentation only

---

Testing

How was this tested / how should reviewers verify it?

---

Checklist

• Breaking changes are clearly described (and announced in docs / changelog if needed)
• Tests were added or updated if needed
• Docs were updated if behavior or public API changed

[Copilot]

Pull request overview

Fixes fault reactivation behavior so that faults in CLEARED state can transition back to an active state when new FAILED events arrive (closing #144).

Changes:

• Allow CLEARED → (PREFAILED/CONFIRMED) transitions on new FAILED events (both in-memory and SQLite storage).
• Reset debounce counter on reactivation and increment occurrence_count, updating sources/description as appropriate.
• Update/extend unit + integration tests to cover cleared-fault reactivation behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/ros2_medkit_fault_manager/src/fault_storage.cpp	Enables reactivation of CLEARED faults in in-memory storage by handling FAILED events specially.
src/ros2_medkit_fault_manager/src/sqlite_fault_storage.cpp	Enables reactivation of CLEARED faults in SQLite storage by updating status/counters/sources on FAILED events.
src/ros2_medkit_fault_manager/test/test_fault_manager.cpp	Updates unit tests for in-memory storage to validate reactivation, PASSED-ignore behavior, and debounce restart.
src/ros2_medkit_fault_manager/test/test_sqlite_storage.cpp	Updates unit tests for SQLite storage to validate reactivation, PASSED-ignore behavior, and debounce restart.
src/ros2_medkit_fault_manager/test/test_integration.test.py	Adds an integration test ensuring a CLEARED fault becomes active again after a new FAILED report.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.