-
Notifications
You must be signed in to change notification settings - Fork 0
Add Docker publish workflow to ghcr #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add docker-publish.yml workflow for automatic image publishing - PR to main: build only (validation) - Push to main: publish as 'latest' - Git tag v*: publish with semver tags (1.2.3, 1.2, 1) - Multi-platform builds (linux/amd64, linux/arm64) - Remove docker-build job from ci.yml (consolidated) - Add Docker Hub badge and tagging docs to README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds a GitHub Actions workflow to build and publish multi-arch Docker images to Docker Hub, and updates CI/docs accordingly.
Changes:
- Introduces
.github/workflows/docker-publish.ymlto build on PRs and publish onmain/v*tags. - Removes the standalone Docker build job from
ci.yml(consolidation). - Updates
README.mdwith Docker Hub badge, pull instructions, and tag documentation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| README.md | Adds Docker Hub badge, pull/run instructions, and tag/arch documentation. |
| .github/workflows/docker-publish.yml | New workflow to build/push multi-platform Docker images with tags derived from branch/tag/SHA. |
| .github/workflows/ci.yml | Removes the old Docker build job now covered by the new workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Remove unused REGISTRY env var - Remove packages:write permission (not needed for Docker Hub) - Fix SHA tag prefix to 'sha-' to match docs - Use linux/amd64 only (arm64 QEMU emulation fails on npm ci) - Update README with known limitation note
|
I will check if we can use selfpatch and ghcr for docker images |
- Use ghcr.io/selfpatch/sovd_web_ui as image name - Authenticate with GITHUB_TOKEN (no extra secrets needed) - packages:write permission required for GHCR - Update README with GHCR badge and pull instructions
Pull Request
Summary
Switched to linux/amd64 only due to QEMU emulation issues with npm ci on arm64. Added note to README about this known limitation. ARM64 support can be added later with native ARM runners or a different build approach.
Issue
Link the related issue (required):
Type
Testing
How was this tested / how should reviewers verify it?
on CI
Checklist
npm run lint)npm run build)