Skip to content

Conversation

@bburda
Copy link
Contributor

@bburda bburda commented Jan 25, 2026

Pull Request

Summary

  • Add docker-publish.yml workflow for automatic image publishing
    • PR to main: build only (validation)
    • Push to main: publish as 'latest'
    • Git tag v*: publish with semver tags (1.2.3, 1.2, 1)
  • Remove docker-build job from ci.yml (consolidated)
  • Add Docker Hub badge and tagging docs to README

Switched to linux/amd64 only due to QEMU emulation issues with npm ci on arm64. Added note to README about this known limitation. ARM64 support can be added later with native ARM runners or a different build approach.


Issue

Link the related issue (required):


Type

  • Bug fix
  • New feature
  • Breaking change
  • Documentation only

Testing

How was this tested / how should reviewers verify it?

on CI


Checklist

  • Breaking changes are clearly described (and announced in docs / changelog if needed)
  • Linting passes (npm run lint)
  • Build succeeds (npm run build)
  • Docs were updated if behavior or public API changed

- Add docker-publish.yml workflow for automatic image publishing
  - PR to main: build only (validation)
  - Push to main: publish as 'latest'
  - Git tag v*: publish with semver tags (1.2.3, 1.2, 1)
- Multi-platform builds (linux/amd64, linux/arm64)
- Remove docker-build job from ci.yml (consolidated)
- Add Docker Hub badge and tagging docs to README
@bburda bburda requested a review from mfaferek93 January 25, 2026 10:48
@bburda bburda self-assigned this Jan 25, 2026
@bburda bburda added the enhancement New feature or request label Jan 25, 2026
Copilot AI review requested due to automatic review settings January 25, 2026 10:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a GitHub Actions workflow to build and publish multi-arch Docker images to Docker Hub, and updates CI/docs accordingly.

Changes:

  • Introduces .github/workflows/docker-publish.yml to build on PRs and publish on main/v* tags.
  • Removes the standalone Docker build job from ci.yml (consolidation).
  • Updates README.md with Docker Hub badge, pull instructions, and tag documentation.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
README.md Adds Docker Hub badge, pull/run instructions, and tag/arch documentation.
.github/workflows/docker-publish.yml New workflow to build/push multi-platform Docker images with tags derived from branch/tag/SHA.
.github/workflows/ci.yml Removes the old Docker build job now covered by the new workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Remove unused REGISTRY env var
- Remove packages:write permission (not needed for Docker Hub)
- Fix SHA tag prefix to 'sha-' to match docs
- Use linux/amd64 only (arm64 QEMU emulation fails on npm ci)
- Update README with known limitation note
@bburda bburda marked this pull request as draft January 25, 2026 12:21
@bburda
Copy link
Contributor Author

bburda commented Jan 25, 2026

I will check if we can use selfpatch and ghcr for docker images

- Use ghcr.io/selfpatch/sovd_web_ui as image name
- Authenticate with GITHUB_TOKEN (no extra secrets needed)
- packages:write permission required for GHCR
- Update README with GHCR badge and pull instructions
@bburda bburda marked this pull request as ready for review January 25, 2026 15:53
@bburda bburda changed the title Add Docker Hub publish workflow Add Docker publish workflow to ghcr Jan 25, 2026
@bburda bburda merged commit dfbceca into main Jan 25, 2026
2 checks passed
@bburda bburda deleted the feat/docker-push branch January 25, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatic Docker image publishing to Docker Hub

3 participants