Feature/fixcosmosdb #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll be more readable. Changes some datastructures to dicts where appropriate.
…nch to write more unified testing.
Closed
Member
There was a problem hiding this comment.
I like alphabetical order for my arbitrary orderings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some things of note here:
First, the high linecount of the new intitialization script is on purpose, while I recognize it's an unorthodox choice, I think it's good to have one entry per line for maintainbility / cleanliness's sake. It doesn't really wrap to 80 chars nice otherwise in a lot of cases.
Second, the testing isn't gone (from the project), it's just been split out into another branch, because it needs a lot of help to stop being a very special snowflake indeed. Check out feature/unittesting.
Lastly, let me know if I forgot someone in the contributors file. It's entirely possible I did.