Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-SNOW: Add python version constraints to noarch build #3110

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sfc-gh-aalam
Copy link
Contributor

@sfc-gh-aalam sfc-gh-aalam commented Mar 4, 2025

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-aalam sfc-gh-aalam changed the title Add python version constraints to noarch build NO-SNOW: Add python version constraints to noarch build Mar 4, 2025
@sfc-gh-aalam
Copy link
Contributor Author

sfc-gh-aalam commented Mar 4, 2025

https://snowpark-python-001.jenkinsdev1.us-west-2.aws-dev.app.snowflake.com/job/SnowparkPythonNoarchPackageBuilder/197462/

downloading the packages and running conda index . gives repodata.json with following dependencies

...
...
"snowflake-snowpark-python-1.29.0-py310_0.tar.bz2": {
      "build": "py310_0",
      "build_number": 0,
      "constrains": [
        "modin==0.30.1"
      ],
      "depends": [
        "cloudpickle >=1.6.0,<=3.0.0,!=2.1.0,!=2.2.0",
        "libffi <=3.4.4",
        "protobuf >=3.20,<6",
        "python >=3.10,<3.11.0a0",
        "python-dateutil",
        "pyyaml",
        "snowflake-connector-python >=3.12.0,<4.0.0",
        "typing-extensions >=4.1.0,<5.0.0",
        "tzlocal"
      ],
...
"snowflake-snowpark-python-1.29.0-py311_0.tar.bz2": {
      "build": "py311_0",
      "build_number": 0,
      "constrains": [
        "modin==0.30.1"
      ],
      "depends": [
        "cloudpickle >=1.6.0,<=3.0.0,!=2.1.0,!=2.2.0",
        "libffi <=3.4.4",
        "protobuf >=3.20,<6",
        "python >=3.11,<3.12.0a0",
        "python-dateutil",
        "pyyaml",
        "snowflake-connector-python >=3.12.0,<4.0.0",
        "typing-extensions >=4.1.0,<5.0.0",
        "tzlocal"
      ],
...

@sfc-gh-aalam sfc-gh-aalam marked this pull request as ready for review March 4, 2025 00:30
@sfc-gh-aalam sfc-gh-aalam requested a review from a team as a code owner March 4, 2025 00:30
- python >=3.11,<3.12.0a0
{% elif noarch_build and py == 312 %}
- python >=3.12,<3.13.0a0
{% else %}
- python

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just assert here instead? Otherwise people might forget updating this in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to add asserts to meta.yaml file. Can you share a source/code suggestion here if you know how to do it?

@sfc-gh-aalam sfc-gh-aalam added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants