Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-SNOW: Add python version constraints to noarch build #3110

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

NO-SNOW: Add python version constraints to noarch build #3110

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c4c7a3
Add python version constraints to noarch build
sfc-gh-aalam Mar 4, 2025
307c800
Merge branch 'main' into aalam-fix-python-version-constraints
sfc-gh-aalam Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,17 @@ requirements:
- protobuf==4.25.3 # [py>310]
- mypy-protobuf
run:
{% if noarch_build and py == 39 %}
- python >=3.9,<3.10.0a0
{% elif noarch_build and py == 310 %}
- python >=3.10,<3.11.0a0
{% elif noarch_build and py == 311 %}
- python >=3.11,<3.12.0a0
{% elif noarch_build and py == 312 %}
- python >=3.12,<3.13.0a0
{% else %}
- python
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just assert here instead? Otherwise people might forget updating this in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to add asserts to meta.yaml file. Can you share a source/code suggestion here if you know how to do it?

{% endif %}
- cloudpickle >=1.6.0,<=3.0.0,!=2.1.0,!=2.2.0
- snowflake-connector-python >=3.12.0,<4.0.0
- typing-extensions >=4.1.0,<5.0.0
Expand Down
Loading