-
Notifications
You must be signed in to change notification settings - Fork 341
[LinearAlgebra] Speedup accumulation on BTDMatrix #4248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[ci-build][with-all-tests] |
I am not sure that this new function is called. I think #4253 must be merged first. Anyway, I don't expect a huge speedup in a scene. This kind of speed up is significant with a high number of DoFs, and it's not the case when using beams. I expect that you save a few microseconds by time step, which is really not significant. |
Indeed ! 🚀 master; master+ this branch + #4253 : |
|
@fredroy thanks for the benchmark. I am pleased with the results. |
This was on WIndows11+MSVC2022 ; on ubuntu/gcc no speedups 😓 |
Validated with the following benchmark. The benchmark
BM_BTDMatrix_addBlockuses the new implemented accumulation function and must be compared toBM_BTDMatrix_add.alxbilger/SofaBenchmark#36
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if