[GL] Modify the FFMPeg recorder to be able to use it in SofaGLFW #5862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

fredroy merged 5 commits into sofa-framework:master from bakpaul:26_01_use_sofa_gl_ffmpegrecoder_instead_master

Jan 16, 2026

+22 −11

Contributor

bakpaul commented Jan 14, 2026 •

edited

Loading

⚠️ based on #5865

This pr modifes the recorder to use a custom buffer instead, thus allowing to use it in GLFW seamlessly. Tested on Sofa.Qt

[ci-depends-on https://github.com/sofa-framework/SofaGLFW/pull/262]

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

it builds with SUCCESS for all platforms on the CI.
it does not generate new warnings.
it does not generate new unit test failures.
it does not generate new scene test failures.
it does not break API compatibility.
it is more than 1 week old (or has fast-merge label).

bakpaul added pr: status to review pr: new feature pr: backport todo labels

Collaborator

sofabot commented Jan 14, 2026

[ci-depends-on] detected during build #1.

To unlock the merge button, you must

Merge or close Use Sofa/GL VideoRecorderFFMPEG SofaGLFW#262
For this build, the following CMake flags will be set
-DSOFAGLFW_GIT_REPOSITORY='https://github.com/sofa-framework/SofaGLFW'
-DSOFAGLFW_GIT_TAG='0b3fa9e0d8d1488ef981c4838b0a3ebca8683c5e'

bakpaul added the topic for next dev-meeting label

bakpaul force-pushed the 26_01_use_sofa_gl_ffmpegrecoder_instead_master branch from 77db961 to cebfab6 Compare

January 15, 2026 14:59

Collaborator

sofabot commented Jan 15, 2026

[ci-depends-on] detected during build #2.

To unlock the merge button, you must

Merge or close Use Sofa/GL VideoRecorderFFMPEG SofaGLFW#262
For this build, the following CMake flags will be set
-DSOFAGLFW_GIT_REPOSITORY='https://github.com/sofa-framework/SofaGLFW'
-DSOFAGLFW_GIT_TAG='b58559ceb1a754bea160ade4ccb5959d18ee54c3'

bakpaul added the pr: based on previous PR label

Contributor Author

bakpaul commented Jan 15, 2026

[ci-build][force-full-build]

Collaborator

sofabot commented Jan 15, 2026

[ci-depends-on] detected during build #3.

To unlock the merge button, you must

Merge or close Use Sofa/GL VideoRecorderFFMPEG SofaGLFW#262
For this build, the following CMake flags will be set
-DSOFAGLFW_GIT_REPOSITORY='https://github.com/sofa-framework/SofaGLFW'
-DSOFAGLFW_GIT_TAG='a1193a0032e621647db158758f3edbb2055a73a8'

bakpaul added pr: fast merge and removed topic for next dev-meeting labels

bakpaul added 3 commits

January 16, 2026 10:35


          Add a quiet option for some filesystem methods that only perform test…

6210b22

…s while keeping old behavior s default for compatibility


          Modify the FFMPeg recorder to be able to use it in SofaGLFW

750f1a1


          Quietly check for file exists

81af902

fredroy force-pushed the 26_01_use_sofa_gl_ffmpegrecoder_instead_master branch from cebfab6 to 81af902 Compare

January 16, 2026 01:35

Collaborator

sofabot commented Jan 16, 2026

[ci-depends-on] detected during build #4.

To unlock the merge button, you must

Merge or close Use Sofa/GL VideoRecorderFFMPEG SofaGLFW#262
For this build, the following CMake flags will be set
-DSOFAGLFW_GIT_REPOSITORY='https://github.com/sofa-framework/SofaGLFW'
-DSOFAGLFW_GIT_TAG='a1193a0032e621647db158758f3edbb2055a73a8'


          Merge branch 'master' into 26_01_use_sofa_gl_ffmpegrecoder_instead_ma…

cde5a7a

…ster

Collaborator

sofabot commented Jan 16, 2026

[ci-depends-on] detected during build #5.

To unlock the merge button, you must

Merge or close Use Sofa/GL VideoRecorderFFMPEG SofaGLFW#262
For this build, the following CMake flags will be set
-DSOFAGLFW_GIT_REPOSITORY='https://github.com/sofa-framework/SofaGLFW'
-DSOFAGLFW_GIT_TAG='a1193a0032e621647db158758f3edbb2055a73a8'

hugtalbot removed the pr: based on previous PR label


          Merge branch 'master' into 26_01_use_sofa_gl_ffmpegrecoder_instead_ma…

6c1bb76

…ster

Collaborator

sofabot commented Jan 16, 2026

[ci-depends-on] detected during build #6.

To unlock the merge button, you must

Merge or close Use Sofa/GL VideoRecorderFFMPEG SofaGLFW#262
For this build, the following CMake flags will be set
-DSOFAGLFW_GIT_REPOSITORY='https://github.com/sofa-framework/SofaGLFW'
-DSOFAGLFW_GIT_TAG='a1193a0032e621647db158758f3edbb2055a73a8'

fredroy approved these changes

View reviewed changes

Contributor

fredroy commented Jan 16, 2026

[ci-build]

Collaborator

sofabot commented Jan 16, 2026

[ci-depends-on] detected during build #7.

All dependencies are merged/closed. Congrats! 👍

fredroy merged commit 91ab29c into sofa-framework:master

12 of 14 checks passed

fredroy added pr: status ready and removed pr: status to review labels

bakpaul added a commit that referenced this pull request


          [GL] Modify the FFMPeg recorder to be able to use it in SofaGLFW (#5862)

87f859e

* Add a quiet option for some filesystem methods that only perform tests while keeping old behavior s default for compatibility

* Modify the FFMPeg recorder to be able to use it in SofaGLFW

* Quietly check for file exists

---------

Co-authored-by: Hugo <[email protected]>

bakpaul removed the pr: backport todo label

bakpaul added the pr: backport done label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: backport done pr: fast merge pr: new feature pr: status ready