Skip to content

Conversation

@epernod
Copy link
Contributor

@epernod epernod commented Jan 20, 2026

Just checking that the regression fails if the state reference file (based on the mechanicalObject name) is not found

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@epernod
Copy link
Contributor Author

epernod commented Jan 20, 2026

[ci-build][with-all-tests]

@hugtalbot hugtalbot added the pr: status to review To notify reviewers to review this pull-request label Jan 20, 2026
@epernod
Copy link
Contributor Author

epernod commented Jan 20, 2026

I'm afraid to say that my fear were right. There is a mismatch of reference filename against current mechanicalObject names. And the ReadState is not returning false if the ref is not found.

You can see that I change the name of a mechanicalObject and totally mess up the mass of several torus in the chain.scn but the regression is still passing:

[INFO] [BaseRegression_test::runStateRegressionTest] Testing /workspace/sofa/examples/Demos/chainAll.scn
[ OK ] Regression_test/StateRegression_test.sceneTest/chainAll_scn (7416 ms)
[ RUN ] Regression_test/StateRegression_test.sceneTest/chainHybrid_scn

@epernod epernod marked this pull request as draft January 20, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: project-ci-infrastructure pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants