Skip to content

[Core] Fix warning in CollisionModel #5894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fredroy merged 2 commits into from
Jan 27, 2026
+8 −1
Merged

[Core] Fix warning in CollisionModel #5894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f297e3d
[Core] Fix warning in CollisionModel
Jan 27, 2026
c890d70
Apply suggestions from code review
hugtalbot Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Sofa/framework/Core/src/sofa/core/CollisionModel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,13 @@ void CollisionModel::setPrevious(CollisionModel::SPtr val)
val->next.set(this);
}

void CollisionModel::computeContinuousBoundingTree(SReal dt, ContinuousIntersectionTypeFlag continuousIntersectionFlag, int maxDepth)
{
SOFA_UNUSED(dt);
SOFA_UNUSED(continuousIntersectionFlag);
computeBoundingTree(maxDepth);
}

void CollisionModel::draw(const core::visual::VisualParams* vparams)
{
// don't draw if the component is not in valid state
Expand Down
2 changes: 1 addition & 1 deletion Sofa/framework/Core/src/sofa/core/CollisionModel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ class SOFA_CORE_API CollisionModel : public virtual objectmodel::BaseObject
/// within the given timestep.
///
/// Default to computeBoundingTree().
virtual void computeContinuousBoundingTree(SReal /*dt*/, ContinuousIntersectionTypeFlag continuousIntersectionFlag = ContinuousIntersectionTypeFlag::Inertia, int maxDepth=0) { computeBoundingTree(maxDepth); }
virtual void computeContinuousBoundingTree(SReal dt, ContinuousIntersectionTypeFlag continuousIntersectionFlag = ContinuousIntersectionTypeFlag::Inertia, int maxDepth=0);

/// \brief Return the list (as a pair of iterators) of <i>internal children</i> of
/// an element.
Expand Down
Loading