Skip to content

Update RNSScreenShadowNode.h#3105

Closed
sharifhh wants to merge 2 commits into
software-mansion:mainfrom
sharifhh:patch-2
Closed

Update RNSScreenShadowNode.h#3105
sharifhh wants to merge 2 commits into
software-mansion:mainfrom
sharifhh:patch-2

Conversation

@sharifhh

@sharifhh sharifhh commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

Description

Fix deprecated shared type
for some reason it is breaking Android build on RN 81 altho it is a deprecation notice but it is showing error.

Changes

Fix Shared to std::shared

Test code and steps to reproduce

Install react-native-screens on 81 and try to build Android.

Checklist

@kkafar

kkafar commented Aug 11, 2025

Copy link
Copy Markdown
Member

Hey @sharifhh, it breaks Android build, because the type was removed from react-native core in 0.81.

Thanks for the effort! We're working on support for 0.81 here: #3114 and this change is already included.

Therefore, despite the patch being accurate I won't land it :sorry:

Thank you!

@kkafar kkafar closed this Aug 11, 2025
@sharifhh

Copy link
Copy Markdown
Contributor Author

that's fine, anyway with the patch the app was crashing every 20-30 seconds, will be waiting for you to merge the PR for the upgrade 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants