Skip to content

Update RNSScreenShadowNode.h #3105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sharifhh wants to merge 2 commits into from
Closed

Update RNSScreenShadowNode.h #3105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f632ba
Update RNSScreenShadowNode.h
sharifhh Aug 7, 2025
190ddef
Update RNSScreenShadowNode.cpp
sharifhh Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions common/cpp/react/renderer/components/rnscreens/RNSScreenShadowNode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ Point RNSScreenShadowNode::getContentOriginOffset(
return stateData.contentOffset;
}

std::optional<std::reference_wrapper<const ShadowNode::Shared>>
std::optional<std::reference_wrapper<const std::shared_ptr<const ShadowNode>>>
findHeaderConfigChild(const YogaLayoutableShadowNode &screenShadowNode) {
for (const ShadowNode::Shared &child : screenShadowNode.getChildren()) {
for (const std::shared_ptr<const ShadowNode> &child : screenShadowNode.getChildren()) {
if (std::strcmp(child->getComponentName(), "RNSScreenStackHeaderConfig") ==
0) {
return {std::cref(child)};
Expand Down Expand Up @@ -81,7 +81,7 @@ std::optional<float> findHeaderHeight(
}
#endif // ANDROID

void RNSScreenShadowNode::appendChild(const ShadowNode::Shared &child) {
void RNSScreenShadowNode::appendChild(const std::shared_ptr<const ShadowNode> &child) {
YogaLayoutableShadowNode::appendChild(child);
#ifdef ANDROID
const auto &stateData = getStateData();
Expand Down
2 changes: 1 addition & 1 deletion common/cpp/react/renderer/components/rnscreens/RNSScreenShadowNode.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class JSI_EXPORT RNSScreenShadowNode final : public ConcreteViewShadowNode<

Point getContentOriginOffset(bool includeTransform) const override;

void appendChild(const ShadowNode::Shared &child) override;
void appendChild(const std::shared_ptr<const ShadowNode> &child) override;

void layout(LayoutContext layoutContext) override;

Expand Down