fix(i18n): improve French translation quality and automation context - #1022
Merged
Conversation
GuiBibeau
marked this pull request as ready for review
July 31, 2026 03:47
…' into codex/french-translation-quality
Collaborator
Author
|
@greptileai review |
Contributor
Greptile SummaryImproves French localization quality and automates catalog ownership enforcement.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported fork branch-name spoof is closed by requiring matching non-empty head and base repository identities, with regression coverage for spoofed and missing identity. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
ProductPR[Product PR] --> English[English source catalogs only]
TranslationPR[Translation-quality PR] --> Localized[Localized catalogs only]
English --> Merge[Merge to main]
Merge --> Eve[Eve finds and translates missing keys]
Eve --> Release[Same-repository codex/release-main PR]
Release --> Mixed[Validated source and localized catalogs]
English --> Policy[Catalog policy CI]
Localized --> Policy
Mixed --> Policy
Reviews (4): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile |
Collaborator
Author
|
@greptileai review |
Collaborator
Author
|
@greptileai review |
Collaborator
Author
|
QA-ready: Greptile is 5/5 on the latest head with no unresolved review threads, every required check is green, and the French catalog, Eve context/glossary flow, English-only product PR policy, secure release exemption, and Greptile guidance have been validated. |
…ion-quality # Conflicts: # apps/sdp-web/messages/fr/dashboard-policies.json
multipletwigs
approved these changes
Jul 31, 2026
GuiBibeau
enabled auto-merge (squash)
July 31, 2026 05:26
This was referenced Jul 31, 2026
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Token,Wallet,mint,burn,allowlist,blocklist,on-chain,endpoint, andAPI Playground.actif,contrepartie,transfert,fournisseur,devis,brouillon, anddéploiement..github/translation-guidance.jsonas the French voice and terminology source of truth, with deterministic rejection of discouraged literal terms such asjetonandportefeuille.codex/release-main.Why
The original French catalog intended to preserve institutional Web3 vocabulary, but later additions drifted into literal and inconsistent translations. Eve previously received only
file,key, and the isolated English source string, so it lacked product context and an enforceable glossary. TypeScript's strict catalog parity also forced feature authors to update French manually, conflicting with release automation, while Greptile had no repository instruction explaining that ownership boundary.Impact
Product authors update English copy only. French users see the English source temporarily if a brand-new key lands before the release sync. Eve then translates the missing keys with local UI context and enforced terminology on the release PR. Dedicated translation-quality PRs remain possible without mixing source and localized copy.
Validation
pnpm test:scripts— 45 passedpnpm --filter sdp-web typecheckpnpm --filter sdp-web exec vitest run src/i18n/messages.unit.test.ts— 5 passedpnpm --dir agents/sdp-translation-agent typecheckpnpm --dir agents/sdp-translation-agent buildpnpm --filter sdp-web check:i18nstill reports pre-existing hard-coded copy in unrelated, untouched files; this PR does not add any of those findings.