Skip to content

feat(web): Add complete Spanish UI translation catalogs - #996

Closed
tomiet wants to merge 8 commits into
solana-foundation:mainfrom
tomiet:chore/spanish-ui-translations
Closed

feat(web): Add complete Spanish UI translation catalogs#996
tomiet wants to merge 8 commits into
solana-foundation:mainfrom
tomiet:chore/spanish-ui-translations

Conversation

@tomiet

@tomiet tomiet commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

What

Add Spanish language es alongside English en and French fr with full matching message inventory, keeping institutional crypto terms like Token short and stable for the layout.

Related PRs

#685
#1047

Register es alongside en and fr with a full matching message inventory, keeping institutional crypto terms like Token short and stable for layout.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

@tomiet is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

tomiet and others added 3 commits July 30, 2026 14:57
Bring the PR branch up to date without rebasing.
Catch the es catalogs up to the lock-supply, max-supply, overview, and dashboard error strings added on main, keeping full key parity with English.

Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve i18n wiring conflicts by keeping Spanish registered with the new English-fallback merge path.

Co-authored-by: Cursor <cursoragent@cursor.com>
@greptile-apps

greptile-apps Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds Spanish as a supported dashboard locale.

  • Adds Spanish catalogs for the root, shared, approvals, custody, issuance, payments, and policies namespaces.
  • Registers Spanish locale resolution and catalog loading.
  • Updates i18n documentation and unit coverage for Spanish.

Confidence Score: 4/5

The PR is not yet safe to merge because Spanish users can still receive the entire Private Channels interface in English.

The registered Spanish catalog omits DashboardPrivateChannels, and the recursive merge consequently supplies that namespace from the English source catalog, leaving the previously reported completeness defect unresolved.

Files Needing Attention: apps/sdp-web/src/i18n/messages.ts and apps/sdp-web/messages/es/

Important Files Changed

Filename Overview
apps/sdp-web/src/i18n/messages.ts Registers and merges the Spanish catalogs, but the previously reported catalog-completeness issue remains outstanding.
apps/sdp-web/src/i18n/config.ts Adds Spanish to the supported locale list.
apps/sdp-web/src/i18n/messages.unit.test.ts Extends locale validation and translation-resolution coverage to Spanish.
apps/sdp-web/src/i18n/README.md Documents Spanish support and generalizes localized-catalog workflow guidance.

Reviews (4): Last reviewed commit: "feat(web): translate tokenization-engine..." | Re-trigger Greptile


const esCatalog = {
...es,
...esDashboardApprovals,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Spanish catalog remains incomplete

Several current English source keys are absent from the registered Spanish catalogs, so the fallback merge displays English text such as “Unnamed member,” “Rows per page,” and policy empty states inside the Spanish UI. Add the missing Spanish leaves so this dedicated translation catalog provides the complete inventory described by the PR.

File Used: apps/sdp-web/src/i18n/README.md (source)

Knowledge Base Used: sdp-web dashboard app

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

tomiet and others added 4 commits August 1, 2026 10:58
Bring the PR branch up to date without rebasing.
Translate new shared shell, approvals, and policies strings, and drop obsolete keys removed from English.

Co-authored-by: Cursor <cursoragent@cursor.com>
Bring the PR branch up to date without rebasing.
Catch Spanish issuance catalogs up with the Mosaic / Vulcan Forge deploy-step copy added on main.

Co-authored-by: Cursor <cursoragent@cursor.com>
@tomiet

tomiet commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

Closing this in favour of #1047 to avoid duplicate work💁🏻‍♀️

@tomiet tomiet closed this Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant