feat(web): Add complete French UI translation catalogs - #685
Merged
GuiBibeau merged 11 commits intoJul 21, 2026
Conversation
Register fr alongside en with a full matching message inventory, keeping institutional crypto terms like Token short and stable for layout. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@tomiet is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Greptile SummaryThis PR adds a complete French (
Confidence Score: 4/5Safe to merge after fixing the one mistranslated button label in the recurring payments section. One concrete translation mistake in apps/sdp-web/messages/fr/dashboard-payments.json — the Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[HTTP Request] --> B{sdp-locale cookie?}
B -- valid locale --> C[Use cookie locale]
B -- missing/invalid --> D{Accept-Language header?}
D -- matches supported locale --> E[Use Accept-Language locale]
D -- no match --> F[Fall back to en]
C --> G[getMessages locale]
E --> G
F --> G
G --> H{locale}
H -- en --> I[enMessages]
H -- fr --> J[frMessages]
I --> K[translate key values]
J --> K
K --> L[Rendered UI]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[HTTP Request] --> B{sdp-locale cookie?}
B -- valid locale --> C[Use cookie locale]
B -- missing/invalid --> D{Accept-Language header?}
D -- matches supported locale --> E[Use Accept-Language locale]
D -- no match --> F[Fall back to en]
C --> G[getMessages locale]
E --> G
F --> G
G --> H{locale}
H -- en --> I[enMessages]
H -- fr --> J[frMessages]
I --> K[translate key values]
J --> K
K --> L[Rendered UI]
Reviews (9): Last reviewed commit: "fix(web): type-check French message cata..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Bring the approved PR branch up to date without rebasing.
Keep the fr shared catalog inventory-matched after upstream language picker landed on main. Co-authored-by: Cursor <cursoragent@cursor.com>
Align home and payments activity labels with custody so Transfer is not left in English mid-French UI. Co-authored-by: Cursor <cursoragent@cursor.com>
Bring the approved PR branch up to date without rebasing.
Bring the approved PR branch up to date without rebasing.
Keep the fr catalog inventory-matched after English playground path placeholders were deleted on main. Co-authored-by: Cursor <cursoragent@cursor.com>
Bring the approved PR branch up to date without rebasing.
Keep the fr payments catalog inventory-matched after upstream added playground hint placeholders. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
@greptileai review |
Collaborator
|
@greptileai review |
Collaborator
|
QA-ready: the French catalogs are synchronized with latest |
GuiBibeau
approved these changes
Jul 21, 2026
multipletwigs
approved these changes
Jul 21, 2026
This was referenced Jul 21, 2026
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a complete French (fr) UI message catalog matching the English inventory, and register
frin SDP web i18n config so Accept-Language / sdp-locale can resolve French.Why
The new UI i18n foundation shipped English-only. French needs a full same-shaped catalog, so locale switching doesn't miss keys, while keeping institutional crypto terms like Token short and layout-stable.
Related PRs
#996