Skip to content

Avoid 0036_remove_spquery_selectseries errors on test-panel #7020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2025

Conversation

acwhite211
Copy link
Member

@acwhite211 acwhite211 commented Jul 10, 2025

Fixes #6942

Avoid issues on the test panel with the 0036_remove_spquery_selectseries migration due to the database state being off when it comes to the the selectseries field being present in the spquery table. This is a simple hacky solution, and it would probably be better to investigate fixing the state of these problematic databases.

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add a reverse migration if a migration is present in the PR

Testing instructions

@acwhite211 acwhite211 marked this pull request as ready for review July 11, 2025 18:54
@acwhite211 acwhite211 requested a review from a team July 11, 2025 18:54
@acwhite211 acwhite211 added this to the 7.11.1 milestone Jul 11, 2025
@acwhite211 acwhite211 requested a review from a team July 11, 2025 18:59
@CarolineDenis CarolineDenis linked an issue Jul 11, 2025 that may be closed by this pull request
@CarolineDenis
Copy link
Contributor

CarolineDenis commented Jul 11, 2025

Tried with ojsmnh:

  • Open the db with issue-6708 ==> migrations failed
  • After that, open a copy of the db with this pr ==> migration ran correctly
  • With this pr, reverted migrations to 0027 than reapply ==> works with no errors

Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Select series field isn't there and I didn't run into any errors

@emenslin emenslin requested a review from a team July 14, 2025 14:55
Copy link
Contributor

@pashiav pashiav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • For UX testing, open the QB viewer on the spquery table and make sure that the "Select Series" field does not appear.

Looks good - Select Series does not appear!

@bhumikaguptaa bhumikaguptaa self-requested a review July 15, 2025 15:26
Copy link
Collaborator

@bhumikaguptaa bhumikaguptaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@acwhite211 acwhite211 merged commit 81680b1 into issue-6708 Jul 15, 2025
14 checks passed
@acwhite211 acwhite211 deleted the issue-6942 branch July 15, 2025 15:56
@github-project-automation github-project-automation bot moved this from 📋Back Log to ✅Done in General Tester Board Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Issue with 0036_remove_spquery_selectseries migration
5 participants